-
-
Notifications
You must be signed in to change notification settings - Fork 14
Unify DS tokens integration #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for reablocks-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a comprehensive design system (DS) tokens integration across all UI components, replacing hardcoded styles with standardized design tokens to ensure consistency and maintainability.
- Unifies styling approach by replacing component-specific hardcoded styles with DS tokens
- Updates component APIs to use typed theme interfaces instead of string literals
- Modernizes import patterns to use type-only imports where appropriate
Reviewed Changes
Copilot reviewed 272 out of 383 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/index.css | Removes old CSS custom properties and color palette definitions |
src/layout/Tabs/* | Updates Tab components to use typed theme interfaces and DS tokens |
src/layout/Stepper/* | Refactors Stepper theme to use DS tokens and improves component structure |
src/layout/Stack/* | Simplifies Stack theme by removing legacy variants |
src/layout/List/* | Updates List components to use DS tokens for consistent styling |
src/form/* | Modernizes all form components with DS tokens and typed theme interfaces |
src/elements/* | Updates elements to use DS tokens and adds new Navigation component |
src/layers/* | Refactors overlay components to use DS tokens consistently |
src/typography/* | Updates typography components for DS token integration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
if (notifyChange) { | ||
onChange?.([newMin, currentMax]); | ||
} |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The conditional check for notifyChange
before calling onChange
is inconsistent with the original pattern. Consider using the logical AND operator (notifyChange && onChange?.([newMin, currentMax])
) for consistency with the original code style.
if (notifyChange) { | |
onChange?.([newMin, currentMax]); | |
} | |
notifyChange && onChange?.([newMin, currentMax]); |
Copilot uses AI. Check for mistakes.
Button
Component changes:
default
,success
,error
andwarning
color typesdestructive
color typeghost
variant typeIcon Button
Variants
Colors
Avatar
Checkbox
Dialog
Input
Textarea
List
###JSONTree

Menu
Notification
Radio
Range
Pager
Select
Tabs
Toggle
Tree
Calendar
Callout
DateInput
Kbd
Stepper
CommandPalette
Chip