Skip to content

Conversation

evgenoid
Copy link
Contributor

@evgenoid evgenoid commented Jul 29, 2025

Button

Component changes:

  • Removed default, success, error and warning color types
  • Added destructive color type
  • Added ghost variant type
Screenshot 2025-07-30 at 16 04 07

Icon Button

Variants

Screenshot 2025-07-30 at 16 24 31

Colors

Screenshot 2025-07-30 at 16 23 41 Screenshot 2025-07-30 at 16 23 46 Screenshot 2025-07-30 at 16 23 51

Avatar

Screenshot 2025-07-30 at 17 39 22

Checkbox

Screenshot 2025-08-04 at 13 58 44

Dialog

Screenshot 2025-08-04 at 14 13 32

Input

Screenshot 2025-08-04 at 14 49 07

Textarea

Screenshot 2025-08-04 at 14 49 26

List

Screenshot 2025-08-04 at 14 54 03

###JSONTree
Screenshot 2025-08-04 at 15 02 55

Menu

Screenshot 2025-08-04 at 15 29 37

Notification

Screenshot 2025-08-04 at 15 56 57

Radio

Screenshot 2025-08-04 at 16 10 12

Range

Screenshot 2025-08-05 at 09 18 46

Pager

Screenshot 2025-08-05 at 09 44 42

Select

Screenshot 2025-08-05 at 10 06 23

Tabs

Screenshot 2025-08-11 at 13 06 29

Toggle

Screenshot 2025-08-05 at 11 43 27

Tree

Screenshot 2025-08-05 at 11 46 33

Calendar

Screenshot 2025-08-05 at 14 22 39 Screenshot 2025-08-05 at 14 22 48 Screenshot 2025-08-05 at 14 22 54

Callout

Screenshot 2025-08-05 at 15 21 16

DateInput

Screenshot 2025-08-05 at 16 18 21

Kbd

Screenshot 2025-08-05 at 16 56 32

Stepper

Screenshot 2025-08-06 at 12 19 09 Screenshot 2025-08-06 at 12 19 18 Screenshot 2025-08-06 at 12 19 23

CommandPalette

Screenshot 2025-08-06 at 14 55 05

Chip

Screenshot 2025-08-07 at 11 01 44

Copy link

netlify bot commented Jul 29, 2025

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit 6327fbe
🔍 Latest deploy log https://app.netlify.com/projects/reablocks-storybook/deploys/68f21873edeeac00081a3643
😎 Deploy Preview https://deploy-preview-298--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@steppy452 steppy452 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And one more.. I noticed a small mistake with the debounced input story.. it looks like the instant example is also using debounced 😅

image

some minor stuff, but I think once these are fixed it's good to go 🚀

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a comprehensive design system (DS) tokens integration across all UI components, replacing hardcoded styles with standardized design tokens to ensure consistency and maintainability.

  • Unifies styling approach by replacing component-specific hardcoded styles with DS tokens
  • Updates component APIs to use typed theme interfaces instead of string literals
  • Modernizes import patterns to use type-only imports where appropriate

Reviewed Changes

Copilot reviewed 272 out of 383 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/index.css Removes old CSS custom properties and color palette definitions
src/layout/Tabs/* Updates Tab components to use typed theme interfaces and DS tokens
src/layout/Stepper/* Refactors Stepper theme to use DS tokens and improves component structure
src/layout/Stack/* Simplifies Stack theme by removing legacy variants
src/layout/List/* Updates List components to use DS tokens for consistent styling
src/form/* Modernizes all form components with DS tokens and typed theme interfaces
src/elements/* Updates elements to use DS tokens and adds new Navigation component
src/layers/* Refactors overlay components to use DS tokens consistently
src/typography/* Updates typography components for DS token integration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +87 to +89
if (notifyChange) {
onChange?.([newMin, currentMax]);
}
Copy link

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The conditional check for notifyChange before calling onChange is inconsistent with the original pattern. Consider using the logical AND operator (notifyChange && onChange?.([newMin, currentMax])) for consistency with the original code style.

Suggested change
if (notifyChange) {
onChange?.([newMin, currentMax]);
}
notifyChange && onChange?.([newMin, currentMax]);

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants