Skip to content

chore(ci): disable docker caching#7

Open
smrz2001 wants to merge 1 commit into
mainfrom
ci/docker
Open

chore(ci): disable docker caching#7
smrz2001 wants to merge 1 commit into
mainfrom
ci/docker

Conversation

@smrz2001

@smrz2001 smrz2001 commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@smrz2001
smrz2001 requested a review from islamaliev July 1, 2025 21:22
@smrz2001 smrz2001 self-assigned this Jul 1, 2025
@smrz2001
smrz2001 enabled auto-merge (squash) July 1, 2025 21:22

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: ECR Authentication Fails Due to Misconfigured Secrets

The Public ECR login step is misconfigured, causing authentication failures. It incorrectly attempts to authenticate using AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY instead of an ECR token. Additionally, the AWS_REGION environment variable is inconsistently set, being defined globally from secrets but hardcoded to 'us-east-1' within this specific step.

.github/workflows/docker-publish.yml#L13-L43

IMAGE_NAME: public.ecr.aws/r5b3e0r5/recallnet/recall-synchronizer
AWS_REGION: ${{ secrets.AWS_REGION }}
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
jobs:
build-and-push:
runs-on: self-hosted
permissions:
contents: read
packages: write
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Set up QEMU
uses: docker/setup-qemu-action@v3
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Login to Public ECR
if: github.event_name != 'pull_request'
uses: docker/login-action@v3
with:
registry: ${{ env.REGISTRY }}
username: ${{ env.AWS_ACCESS_KEY_ID }}
password: ${{ env.AWS_SECRET_ACCESS_KEY }}
env:
AWS_REGION: us-east-1

Fix in Cursor


BugBot free trial expires on July 22, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Comment bugbot run to trigger another review on this PR
Was this report helpful? Give feedback by reacting with 👍 or 👎

@smrz2001

smrz2001 commented Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

Bug: ECR Authentication Fails Due to Misconfigured Secrets

The Public ECR login step is misconfigured, causing authentication failures. It incorrectly attempts to authenticate using AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY instead of an ECR token. Additionally, the AWS_REGION environment variable is inconsistently set, being defined globally from secrets but hardcoded to 'us-east-1' within this specific step.

.github/workflows/docker-publish.yml#L13-L43
Fix in Cursor

BugBot free trial expires on July 22, 2025 You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Comment bugbot run to trigger another review on this PR Was this report helpful? Give feedback by reacting with 👍 or 👎

Not sure what it's talking about with the ECR token. Using a token is also a way to do it, but the way I've done it in this PR is what's in the action examples:
https://github.com/docker/login-action#aws-public-elastic-container-registry-ecr

I deleted the region secret, it needs to always be us-east-1 for public repos, so it's hardcoded:
https://docs.aws.amazon.com/AmazonECR/latest/public/public-registry-auth.html#public-registry-auth-token

@smrz2001 smrz2001 changed the title chore(ci): push image to aws ecr chore(ci): disable docker caching Jul 1, 2025
@smrz2001
smrz2001 force-pushed the ci/docker branch 3 times, most recently from 6a1e1a8 to 7e48f07 Compare July 8, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant