Conversation
There was a problem hiding this comment.
Bug: ECR Authentication Fails Due to Misconfigured Secrets
The Public ECR login step is misconfigured, causing authentication failures. It incorrectly attempts to authenticate using AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY instead of an ECR token. Additionally, the AWS_REGION environment variable is inconsistently set, being defined globally from secrets but hardcoded to 'us-east-1' within this specific step.
.github/workflows/docker-publish.yml#L13-L43
recall-synchronizer/.github/workflows/docker-publish.yml
Lines 13 to 43 in 0705fbc
BugBot free trial expires on July 22, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.
Comment bugbot run to trigger another review on this PR
Was this report helpful? Give feedback by reacting with 👍 or 👎
Not sure what it's talking about with the ECR token. Using a token is also a way to do it, but the way I've done it in this PR is what's in the action examples: I deleted the region secret, it needs to always be |
6a1e1a8 to
7e48f07
Compare
No description provided.