Add support for external audio tracks in player #2288
+102
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced the AudioFile data class and related API for handling external audio tracks. Updated ExtractorLink and player logic to support merging separate audio tracks with video playback, allowing for custom audio sources and headers.
Annotated the AudioFile data class with @ConsistentCopyVisibility to ensure consistent visibility behavior, likely for improved API usage or codebase consistency.
fire-light42
reviewed
Dec 3, 2025
Collaborator
fire-light42
left a comment
fire-light42
left a comment
There was a problem hiding this comment.
The code looks good, but I have not tested yet.
app/src/main/java/com/lagradost/cloudstream3/ui/player/CS3IPlayer.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/ui/player/CS3IPlayer.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/ui/player/CS3IPlayer.kt
Outdated
Show resolved
Hide resolved
Replaces manual MediaItem construction with getMediaItem for audio tracks and simplifies header handling by using a local variable. This improves code clarity and consistency in media item creation.
Contributor
Author
|
Refactored. |
Luna712
suggested changes
Dec 4, 2025
Added the @prerelease annotation to the AudioFile data class and the newAudioFile function to indicate their prerelease status.
Contributor
Author
|
Added @prerelease Annotation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced the AudioFile data class and related API for handling external audio tracks. Updated ExtractorLink and player logic to support merging separate audio tracks with video playback, allowing for custom audio sources and headers.