Skip to content

Commit bd51661

Browse files
ranjiGTsanjay-kv
ranjiGT
and
sanjay-kv
authored
chore: harden external links and clean auth flow (#1480)
* fix: correct YouTube link for Pair Extraordinaire badge tutorial Updated the incorrect YouTube URL for the Pair Extraordinaire badge video tutorial in githubbadge.html. Old URL: https://youtu.be/BNKSlT8jLQ0 New URL: https://www.youtube.com/watch?v=ZoNO_e8PjiM Co-authored-by: sanjay-kv <sanjay-kv@users.noreply.github.com> * chore: harden external links and clean auth flow - add rel="noopener noreferrer" for target="_blank" links\n- remove duplicate GitHub auth handler call in login flow\n- remove sensitive OAuth debug logs\n- fix githubbadge HTML cleanup (duplicate CSS include, extra </td>, duplicate FA include) Co-authored-by: sanjay-kv <sanjay-kv@users.noreply.github.com> --------- Co-authored-by: sanjay-kv <sanjay-kv@users.noreply.github.com>
1 parent f6a68db commit bd51661

12 files changed

Lines changed: 49 additions & 76 deletions

File tree

‎index.html‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -81,31 +81,31 @@
8181
<!-- Side Social Icons - commented out for new popup design
8282
<div class="side-icons">
8383
<div class="icon-content">
84-
<a href="https://github.com/sanjay-kv" target="_blank" aria-label="GitHub" data-social="github">
84+
<a href="https://github.com/sanjay-kv" target="_blank" rel="noopener noreferrer" aria-label="GitHub" data-social="github">
8585
<i class="fab fa-github"></i>
8686
<div class="filled"></div>
8787
</a>
8888
</div>
8989
<div class="icon-content">
90-
<a href="https://stream.recodehive.com/github" target="_blank" aria-label="YouTube" data-social="youtube">
90+
<a href="https://stream.recodehive.com/github" target="_blank" rel="noopener noreferrer" aria-label="YouTube" data-social="youtube">
9191
<i class="fab fa-youtube"></i>
9292
<div class="filled"></div>
9393
</a>
9494
</div>
9595
<div class="icon-content">
96-
<a href="https://twitter.com/sanjay_kv_" target="_blank" aria-label="Twitter" data-social="twitter">
96+
<a href="https://twitter.com/sanjay_kv_" target="_blank" rel="noopener noreferrer" aria-label="Twitter" data-social="twitter">
9797
<i class="fa-brands fa-x-twitter"></i>
9898
<div class="filled"></div>
9999
</a>
100100
</div>
101101
<div class="icon-content">
102-
<a href="https://www.linkedin.com/in/sanjay-k-v/" target="_blank" aria-label="LinkedIn" data-social="linkedin">
102+
<a href="https://www.linkedin.com/in/sanjay-k-v/" target="_blank" rel="noopener noreferrer" aria-label="LinkedIn" data-social="linkedin">
103103
<i class="fab fa-linkedin-in"></i>
104104
<div class="filled"></div>
105105
</a>
106106
</div>
107107
<div class="icon-content">
108-
<a href="https://www.facebook.com/sanjay.k.viswanathan/" target="_blank" aria-label="Facebook"
108+
<a href="https://www.facebook.com/sanjay.k.viswanathan/" target="_blank" rel="noopener noreferrer" aria-label="Facebook"
109109
data-social="facebook">
110110
<i class="fab fa-facebook-f"></i>
111111
<div class="filled"></div>
@@ -194,23 +194,23 @@ <h2>No profiles found</h2>
194194

195195
<!-- Social Media Icons -->
196196
<div class="social-media-icons">
197-
<a href="https://github.com/sanjay-kv" target="_blank" aria-label="GitHub" data-social="github">
197+
<a href="https://github.com/sanjay-kv" target="_blank" rel="noopener noreferrer" aria-label="GitHub" data-social="github">
198198
<i class="fab fa-github"></i>
199199
<div class="filled"></div>
200200
</a>
201-
<a href="https://stream.recodehive.com/github" target="_blank" aria-label="YouTube" data-social="youtube">
201+
<a href="https://stream.recodehive.com/github" target="_blank" rel="noopener noreferrer" aria-label="YouTube" data-social="youtube">
202202
<i class="fab fa-youtube footer-youtube-icon"></i>
203203
<div class="filled"></div>
204204
</a>
205-
<a href="https://www.linkedin.com/in/sanjay-k-v/" target="_blank" aria-label="LinkedIn" data-social="linkedin">
205+
<a href="https://www.linkedin.com/in/sanjay-k-v/" target="_blank" rel="noopener noreferrer" aria-label="LinkedIn" data-social="linkedin">
206206
<i class="fab fa-linkedin-in footer-linkedin-icon"></i>
207207
<div class="filled"></div>
208208
</a>
209-
<a href="https://twitter.com/sanjay_kv_" target="_blank" aria-label="Twitter" data-social="twitter">
209+
<a href="https://twitter.com/sanjay_kv_" target="_blank" rel="noopener noreferrer" aria-label="Twitter" data-social="twitter">
210210
<i class="fab fa-twitter footer-twitter-icon"></i>
211211
<div class="filled"></div>
212212
</a>
213-
<a href="https://www.facebook.com/sanjay.k.viswanathan/" target="_blank" aria-label="Facebook" data-social="facebook">
213+
<a href="https://www.facebook.com/sanjay.k.viswanathan/" target="_blank" rel="noopener noreferrer" aria-label="Facebook" data-social="facebook">
214214
<i class="fab fa-facebook-f footer-facebook-icon"></i>
215215
<div class="filled"></div>
216216
</a>

‎login.js‎

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -25,31 +25,25 @@ document.addEventListener("DOMContentLoaded", () => {
2525
const code = params.get("code");
2626

2727
if (code) {
28-
console.log("OAuth code received:", code);
2928
getGhUser(code);
3029
}
3130
};
3231

3332
// Get GitHub user data
3433
const getGhUser = (code) => {
35-
console.log("Starting GitHub user fetch with code:", code);
36-
3734
fetch(`${BACKEND_URL}/api/auth/github?code=${code}`)
3835
.then(res => {
39-
console.log("Auth response status:", res.status);
4036
if (!res.ok) {
4137
throw new Error(`HTTP error! status: ${res.status}`);
4238
}
4339
return res.json();
4440
})
4541
.then(response => {
46-
console.log("Auth response data:", response);
4742
if (!response.data || !response.data.access_token) {
4843
throw new Error('No access token received');
4944
}
5045

5146
const token = response.data.access_token;
52-
console.log("Received access token, fetching user data");
5347

5448
return fetch(`${BACKEND_URL}/api/auth/github/getUser`, {
5549
headers: {
@@ -58,14 +52,12 @@ document.addEventListener("DOMContentLoaded", () => {
5852
});
5953
})
6054
.then(res => {
61-
console.log("User data response status:", res.status);
6255
if (!res.ok) {
6356
throw new Error(`HTTP error! status: ${res.status}`);
6457
}
6558
return res.json();
6659
})
6760
.then(response => {
68-
console.log("User data response:", response);
6961
if (!response.user) {
7062
throw new Error('No user data received');
7163
}
@@ -91,9 +83,4 @@ document.addEventListener("DOMContentLoaded", () => {
9183
if (window.location.search.includes("code")) {
9284
handleGitHubAuth();
9385
}
94-
95-
// Handle GitHub auth on page load
96-
if (window.location.search.includes("code")) {
97-
handleGitHubAuth();
98-
}
9986
});

‎pages/blog.html‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1759,23 +1759,23 @@ <h1 style="font-size: 50px;">Github Profile Review</h1>
17591759

17601760
<!-- Social Media Icons -->
17611761
<div class="social-media-icons">
1762-
<a href="https://github.com/sanjay-kv" target="_blank" aria-label="GitHub" data-social="github">
1762+
<a href="https://github.com/sanjay-kv" target="_blank" rel="noopener noreferrer" aria-label="GitHub" data-social="github">
17631763
<i class="fab fa-github"></i>
17641764
<div class="filled"></div>
17651765
</a>
1766-
<a href="https://stream.recodehive.com/github" target="_blank" aria-label="YouTube" data-social="youtube">
1766+
<a href="https://stream.recodehive.com/github" target="_blank" rel="noopener noreferrer" aria-label="YouTube" data-social="youtube">
17671767
<i class="fab fa-youtube footer-youtube-icon"></i>
17681768
<div class="filled"></div>
17691769
</a>
1770-
<a href="https://www.linkedin.com/in/sanjay-k-v/" target="_blank" aria-label="LinkedIn" data-social="linkedin">
1770+
<a href="https://www.linkedin.com/in/sanjay-k-v/" target="_blank" rel="noopener noreferrer" aria-label="LinkedIn" data-social="linkedin">
17711771
<i class="fab fa-linkedin-in footer-linkedin-icon"></i>
17721772
<div class="filled"></div>
17731773
</a>
1774-
<a href="https://twitter.com/sanjay_kv_" target="_blank" aria-label="Twitter" data-social="twitter">
1774+
<a href="https://twitter.com/sanjay_kv_" target="_blank" rel="noopener noreferrer" aria-label="Twitter" data-social="twitter">
17751775
<i class="fab fa-twitter footer-twitter-icon"></i>
17761776
<div class="filled"></div>
17771777
</a>
1778-
<a href="https://www.facebook.com/sanjay.k.viswanathan/" target="_blank" aria-label="Facebook" data-social="facebook">
1778+
<a href="https://www.facebook.com/sanjay.k.viswanathan/" target="_blank" rel="noopener noreferrer" aria-label="Facebook" data-social="facebook">
17791779
<i class="fab fa-facebook-f footer-facebook-icon"></i>
17801780
<div class="filled"></div>
17811781
</a>

‎pages/compare.html‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -169,23 +169,23 @@ <h2>Contributor Comparison</h2>
169169

170170
<!-- Social Media Icons -->
171171
<div class="social-media-icons">
172-
<a href="https://github.com/sanjay-kv" target="_blank" aria-label="GitHub" data-social="github">
172+
<a href="https://github.com/sanjay-kv" target="_blank" rel="noopener noreferrer" aria-label="GitHub" data-social="github">
173173
<i class="fab fa-github"></i>
174174
<div class="filled"></div>
175175
</a>
176-
<a href="https://stream.recodehive.com/github" target="_blank" aria-label="YouTube" data-social="youtube">
176+
<a href="https://stream.recodehive.com/github" target="_blank" rel="noopener noreferrer" aria-label="YouTube" data-social="youtube">
177177
<i class="fab fa-youtube footer-youtube-icon"></i>
178178
<div class="filled"></div>
179179
</a>
180-
<a href="https://www.linkedin.com/in/sanjay-k-v/" target="_blank" aria-label="LinkedIn" data-social="linkedin">
180+
<a href="https://www.linkedin.com/in/sanjay-k-v/" target="_blank" rel="noopener noreferrer" aria-label="LinkedIn" data-social="linkedin">
181181
<i class="fab fa-linkedin-in footer-linkedin-icon"></i>
182182
<div class="filled"></div>
183183
</a>
184-
<a href="https://twitter.com/sanjay_kv_" target="_blank" aria-label="Twitter" data-social="twitter">
184+
<a href="https://twitter.com/sanjay_kv_" target="_blank" rel="noopener noreferrer" aria-label="Twitter" data-social="twitter">
185185
<i class="fab fa-twitter footer-twitter-icon"></i>
186186
<div class="filled"></div>
187187
</a>
188-
<a href="https://www.facebook.com/sanjay.k.viswanathan/" target="_blank" aria-label="Facebook" data-social="facebook">
188+
<a href="https://www.facebook.com/sanjay.k.viswanathan/" target="_blank" rel="noopener noreferrer" aria-label="Facebook" data-social="facebook">
189189
<i class="fab fa-facebook-f footer-facebook-icon"></i>
190190
<div class="filled"></div>
191191
</a>

‎pages/events.html‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -138,23 +138,23 @@ <h2 class="event-title">GitHub Profile Review Live Session : 3</h2>
138138
</a>
139139
<!-- Social Media Icons -->
140140
<div class="social-media-icons">
141-
<a href="https://github.com/sanjay-kv" target="_blank" aria-label="GitHub" data-social="github">
141+
<a href="https://github.com/sanjay-kv" target="_blank" rel="noopener noreferrer" aria-label="GitHub" data-social="github">
142142
<i class="fab fa-github"></i>
143143
<div class="filled"></div>
144144
</a>
145-
<a href="https://stream.recodehive.com/github" target="_blank" aria-label="YouTube" data-social="youtube">
145+
<a href="https://stream.recodehive.com/github" target="_blank" rel="noopener noreferrer" aria-label="YouTube" data-social="youtube">
146146
<i class="fab fa-youtube footer-youtube-icon"></i>
147147
<div class="filled"></div>
148148
</a>
149-
<a href="https://www.linkedin.com/in/sanjay-k-v/" target="_blank" aria-label="LinkedIn" data-social="linkedin">
149+
<a href="https://www.linkedin.com/in/sanjay-k-v/" target="_blank" rel="noopener noreferrer" aria-label="LinkedIn" data-social="linkedin">
150150
<i class="fab fa-linkedin-in footer-linkedin-icon"></i>
151151
<div class="filled"></div>
152152
</a>
153-
<a href="https://twitter.com/sanjay_kv_" target="_blank" aria-label="Twitter" data-social="twitter">
153+
<a href="https://twitter.com/sanjay_kv_" target="_blank" rel="noopener noreferrer" aria-label="Twitter" data-social="twitter">
154154
<i class="fab fa-twitter footer-twitter-icon"></i>
155155
<div class="filled"></div>
156156
</a>
157-
<a href="https://www.facebook.com/sanjay.k.viswanathan/" target="_blank" aria-label="Facebook" data-social="facebook">
157+
<a href="https://www.facebook.com/sanjay.k.viswanathan/" target="_blank" rel="noopener noreferrer" aria-label="Facebook" data-social="facebook">
158158
<i class="fab fa-facebook-f footer-facebook-icon"></i>
159159
<div class="filled"></div>
160160
</a>

‎pages/faq.html‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -158,23 +158,23 @@ <h2>Frequently Asked Questions</h2>
158158

159159
<!-- Social Media Icons -->
160160
<div class="social-media-icons">
161-
<a href="https://github.com/sanjay-kv" target="_blank" aria-label="GitHub" data-social="github">
161+
<a href="https://github.com/sanjay-kv" target="_blank" rel="noopener noreferrer" aria-label="GitHub" data-social="github">
162162
<i class="fab fa-github"></i>
163163
<div class="filled"></div>
164164
</a>
165-
<a href="https://stream.recodehive.com/github" target="_blank" aria-label="YouTube" data-social="youtube">
165+
<a href="https://stream.recodehive.com/github" target="_blank" rel="noopener noreferrer" aria-label="YouTube" data-social="youtube">
166166
<i class="fab fa-youtube footer-youtube-icon"></i>
167167
<div class="filled"></div>
168168
</a>
169-
<a href="https://www.linkedin.com/in/sanjay-k-v/" target="_blank" aria-label="LinkedIn" data-social="linkedin">
169+
<a href="https://www.linkedin.com/in/sanjay-k-v/" target="_blank" rel="noopener noreferrer" aria-label="LinkedIn" data-social="linkedin">
170170
<i class="fab fa-linkedin-in footer-linkedin-icon"></i>
171171
<div class="filled"></div>
172172
</a>
173-
<a href="https://twitter.com/sanjay_kv_" target="_blank" aria-label="Twitter" data-social="twitter">
173+
<a href="https://twitter.com/sanjay_kv_" target="_blank" rel="noopener noreferrer" aria-label="Twitter" data-social="twitter">
174174
<i class="fab fa-twitter footer-twitter-icon"></i>
175175
<div class="filled"></div>
176176
</a>
177-
<a href="https://www.facebook.com/sanjay.k.viswanathan/" target="_blank" aria-label="Facebook" data-social="facebook">
177+
<a href="https://www.facebook.com/sanjay.k.viswanathan/" target="_blank" rel="noopener noreferrer" aria-label="Facebook" data-social="facebook">
178178
<i class="fab fa-facebook-f footer-facebook-icon"></i>
179179
<div class="filled"></div>
180180
</a>

‎pages/githubbadge.html‎

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
<link href="https://fonts.googleapis.com/css2?family=Roboto:wght@400;500&display=swap" rel="stylesheet" />
1414

1515
<link rel="stylesheet" href="../styles/styles.css">
16-
<link rel="stylesheet" href="../styles/githubbadge.css" />
1716

1817
</head>
1918

@@ -739,11 +738,11 @@ <h1>GitHub Copilot</h1>
739738
<img src="../assets/recode.png" alt="Recode-Hive logo" class="footer-logo">
740739
</a>
741740
<div class="social-media-links">
742-
<a href="https://facebook.com/recodehive" target="_blank" class="social-icon1"><i class="fab fa-facebook-f"></i></a>
743-
<a href="https://twitter.com/recodehive" target="_blank" class="social-icon2"><i class="fab fa-twitter"></i></a>
744-
<a href="https://instagram.com/recodehive" target="_blank" class="social-icon3"><i class="fab fa-instagram"></i></a>
745-
<a href="https://linkedin.com/company/recodehive" target="_blank" class="social-icon4"><i class="fab fa-linkedin-in"></i></a>
746-
<a href="https://github.com/recodehive" target="_blank" class="social-icon5"><i class="fab fa-github"></i></a>
741+
<a href="https://facebook.com/recodehive" target="_blank" rel="noopener noreferrer" class="social-icon1"><i class="fab fa-facebook-f"></i></a>
742+
<a href="https://twitter.com/recodehive" target="_blank" rel="noopener noreferrer" class="social-icon2"><i class="fab fa-twitter"></i></a>
743+
<a href="https://instagram.com/recodehive" target="_blank" rel="noopener noreferrer" class="social-icon3"><i class="fab fa-instagram"></i></a>
744+
<a href="https://linkedin.com/company/recodehive" target="_blank" rel="noopener noreferrer" class="social-icon4"><i class="fab fa-linkedin-in"></i></a>
745+
<a href="https://github.com/recodehive" target="_blank" rel="noopener noreferrer" class="social-icon5"><i class="fab fa-github"></i></a>
747746
</div>
748747
</div>
749748

@@ -789,10 +788,7 @@ <h5>
789788
document.getElementById("dynamic-year").textContent = new Date().getFullYear();
790789
</script>
791790
</footer>
792-
793-
<!-- Link to Font Awesome for icons -->
794-
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.15.4/css/all.min.css">
795-
791+
796792
<!-- Custom CSS for social icons -->
797793
<style>
798794
.social-media-links {

‎pages/help.html‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -174,23 +174,23 @@ <h2>Contact Us</h2>
174174
</a>
175175
<!-- Social Media Icons -->
176176
<div class="social-media-icons">
177-
<a href="https://github.com/sanjay-kv" target="_blank" aria-label="GitHub" data-social="github">
177+
<a href="https://github.com/sanjay-kv" target="_blank" rel="noopener noreferrer" aria-label="GitHub" data-social="github">
178178
<i class="fab fa-github"></i>
179179
<div class="filled"></div>
180180
</a>
181-
<a href="https://stream.recodehive.com/github" target="_blank" aria-label="YouTube" data-social="youtube">
181+
<a href="https://stream.recodehive.com/github" target="_blank" rel="noopener noreferrer" aria-label="YouTube" data-social="youtube">
182182
<i class="fab fa-youtube footer-youtube-icon"></i>
183183
<div class="filled"></div>
184184
</a>
185-
<a href="https://www.linkedin.com/in/sanjay-k-v/" target="_blank" aria-label="LinkedIn" data-social="linkedin">
185+
<a href="https://www.linkedin.com/in/sanjay-k-v/" target="_blank" rel="noopener noreferrer" aria-label="LinkedIn" data-social="linkedin">
186186
<i class="fab fa-linkedin-in footer-linkedin-icon"></i>
187187
<div class="filled"></div>
188188
</a>
189-
<a href="https://twitter.com/sanjay_kv" target="_blank" aria-label="Twitter" data-social="twitter">
189+
<a href="https://twitter.com/sanjay_kv" target="_blank" rel="noopener noreferrer" aria-label="Twitter" data-social="twitter">
190190
<i class="fab fa-twitter footer-twitter-icon"></i>
191191
<div class="filled"></div>
192192
</a>
193-
<a href="https://www.facebook.com/sanjay.k.viswanathan/" target="_blank" aria-label="Facebook" data-social="facebook">
193+
<a href="https://www.facebook.com/sanjay.k.viswanathan/" target="_blank" rel="noopener noreferrer" aria-label="Facebook" data-social="facebook">
194194
<i class="fab fa-facebook-f footer-facebook-icon"></i>
195195
<div class="filled"></div>
196196
</a>

0 commit comments

Comments
 (0)