[Php80] Keep numeric string as is on StringAnnotationToAttributeMapper

[samsonasik]

Fixes rectorphp/rector#8941

[samsonasik]

Fixed 🎉 /cc @Seldaek

[samsonasik]

All checks have passed 🎉 @TomasVotruba I am merging it ;)

[Seldaek]

Thanks for the quick fix, are you sure this isn't gonna cause regressions like will it still treat 2 as int now? Maybe not but I wonder if all the other checks in that file make any sense then.

If you look at this https://getrector.com/demo/ae99daee-198a-4d2c-b948-d9788b3c25b2 - I also don't see why "true" gets turned into true.

Basically if something was a quoted string it should remain so as far as I can tell, not sure why all this magic in StringAnnotationToAttributeMapper was added in the first place.

[samsonasik]

@Seldaek I see, special decorator seems needed for @TestWith to avoid regression, like doctrine decorator

rector-src/rules/Php80/AttributeDecorator/DoctrineConverterAttributeDecorator.php

Line 37 in 72c537a

if (! in_array($value->value, ['true', 'false'], true)) {

I will check

[samsonasik]

I am going to revert it for now, the fix should be in a single PR to ease rollback.

[samsonasik]

Reverted at #6609