Skip to content

Auto color data #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Auto color data #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
574695d
split color_data into separate files in preparation for auto-generati…
nanobowers Jan 25, 2022
ceb8ea0
pulling xkcd and css4 colors per issue #8
nanobowers Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,18 @@ task :test do
end

task default: :test

task :get_xkcd do
xkcd = GetColors::XKCD.new
xkcd.get_data
xkcd.dump_file("lib/colors/color_data/xkcd.rb")
end

task :get_css4 do
css4 = GetColors::CSS4.new
css4.get_data
css4.dump_file("lib/colors/color_data/css4.rb")
end

desc "Get color data files from the web, per issue #8"
Copy link
Member

@kou kou Jan 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to refer #8 here.

Suggested change
desc "Get color data files from the web, per issue #8"
desc "Get color data files from the web"

task :get_colors => [:get_xkcd, :get_css4]
Copy link
Member

@kou kou Jan 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about colors:generate?

Suggested change
task :get_colors => [:get_xkcd, :get_css4]
namespace :colors do
namespace :generate do
task :xkcd do
# ...
end
task :css4 do
# ...
end
end
task :generate => [:xkcd, :css4]
end

Loading