[rhoai-2.25] Add pytorch-llmcompressor PR pipeline and FIPS check blocking - #2233
[rhoai-2.25] Add pytorch-llmcompressor PR pipeline and FIPS check blocking#2233yash2189 wants to merge 0 commit into
Conversation
📝 WalkthroughWalkthroughThis PR adds a new ChangesFIPS-Blocking Parameter and PyTorch LLMCompressor Runtime
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4891374 to
f28965d
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.tekton/odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-pull-request.yaml (1)
43-43: Consider documenting why hermetic builds are disabled.Setting
hermetic: falsedisables hermetic builds, which can impact build reproducibility and supply chain security. If this is intentional due to specific runtime requirements (e.g., network access during build for PyTorch/LLMCompressor dependencies), consider adding a comment to document the rationale.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.tekton/odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-pull-request.yaml at line 43, Add a concise comment explaining why hermetic: false is used (e.g., required network access to fetch PyTorch/LLMCompressor binaries or other runtime-only dependencies) so readers understand the intentional tradeoff; update the YAML near the hermetic: false setting to document the specific rationale, any security/replicability implications, and any mitigation steps (pinning versions, verifying artifacts, or CI-only allowances) and reference the related runtime requirement that necessitates non-hermetic builds.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
@.tekton/odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-pull-request.yaml:
- Line 43: Add a concise comment explaining why hermetic: false is used (e.g.,
required network access to fetch PyTorch/LLMCompressor binaries or other
runtime-only dependencies) so readers understand the intentional tradeoff;
update the YAML near the hermetic: false setting to document the specific
rationale, any security/replicability implications, and any mitigation steps
(pinning versions, verifying artifacts, or CI-only allowances) and reference the
related runtime requirement that necessitates non-hermetic builds.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 1a60772d-1635-455a-b5b8-2eab9a90f07f
📒 Files selected for processing (18)
.tekton/odh-pipeline-runtime-datascience-cpu-py312-pull-request.yaml.tekton/odh-pipeline-runtime-minimal-cpu-py312-pull-request.yaml.tekton/odh-pipeline-runtime-pytorch-cuda-py312-pull-request.yaml.tekton/odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-pull-request.yaml.tekton/odh-pipeline-runtime-pytorch-rocm-py312-pull-request.yaml.tekton/odh-pipeline-runtime-tensorflow-cuda-py312-pull-request.yaml.tekton/odh-pipeline-runtime-tensorflow-rocm-py312-pull-request.yaml.tekton/odh-workbench-codeserver-datascience-cpu-py312-pull-request.yaml.tekton/odh-workbench-jupyter-datascience-cpu-py312-pull-request.yaml.tekton/odh-workbench-jupyter-minimal-cpu-py312-pull-request.yaml.tekton/odh-workbench-jupyter-minimal-cuda-py312-pull-request.yaml.tekton/odh-workbench-jupyter-minimal-rocm-py312-pull-request.yaml.tekton/odh-workbench-jupyter-pytorch-cuda-py312-pull-request.yaml.tekton/odh-workbench-jupyter-pytorch-llmcompressor-cuda-py312-pull-request.yaml.tekton/odh-workbench-jupyter-pytorch-rocm-py312-pull-request.yaml.tekton/odh-workbench-jupyter-tensorflow-cuda-py312-pull-request.yaml.tekton/odh-workbench-jupyter-tensorflow-rocm-py312-pull-request.yaml.tekton/odh-workbench-jupyter-trustyai-cpu-py312-pull-request.yaml
yash2189
changed the title
f28965d to
1c4d0d5
Compare
|
/build-konflux |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
jiridanek
changed the title
PR Review: #2233Verdict: Do not merge — close as superseded. The PR’s intent is sound, but the work is already on What the PR tries to do
Both are reasonable and match existing patterns (push pipelines already use Critical: work already landed on
|
| Change | Already on rhoai-2.25 |
Via |
|---|---|---|
fips-check-blocking on all PR pipelines |
Yes | #2355 (2026-06-12) |
| llmcompressor runtime PR pipeline | Yes | RHAIENG-6036 commit by jiridanek (2026-07-03) |
Component-specific on-comment triggers |
Yes | Commit by Vath. Sok (2026-07-15) |
Raw comparison of the llmcompressor runtime file shows base is better than this PR branch:
# PR branch adds (wrong):
+ # retrigger Konflux builds to fix RHOAIENG-31914 # stale, copied from pytorch-cuda
# PR branch has narrower trigger (wrong):
< on-comment: "^/(build-konflux|build-runtime-pytorch-llmcompressor)" # rhoai-2.25
> on-comment: "^/build-konflux" # PR branchfips-check-blocking is identical on both branches for files like odh-pipeline-runtime-datascience-cpu-py312-pull-request.yaml.
PR hygiene issues (if it were still needed)
| Issue | Status |
|---|---|
Draft / do-not-merge/work-in-progress |
Open |
needs-rebase + merge conflict (tide error) |
Open |
| Checklist unchecked | All items unchecked |
| Commit message | Added pr request pipeline , fips-check missing — not conventional |
| Testing | No Konflux /build-konflux or /build-runtime-pytorch-llmcompressor evidence documented |
CodeRabbit nit on hermetic: false |
Low priority — consistent with other CUDA runtime PR pipelines |
Code quality notes (for reference)
fips-check-blocking additions — Correct pattern, placed consistently after enable-slack-failure-notification, value "false" matches push pipelines and konflux-central.
New llmcompressor runtime pipeline — Structure mirrors odh-pipeline-runtime-pytorch-cuda-py312-pull-request.yaml (dockerfile paths, taskRunSpecs, timeouts, service account). Issues in the PR version:
- Missing component trigger
build-runtime-pytorch-llmcompressor(workbench usesbuild-pytorch-llmcompressor; runtime should followbuild-runtime-*convention). - Stale RHOAIENG-31914 retrigger comment — inappropriate on a new file.
rhoai-version: "2.25.3"— consistent with other PR pipelines (push uses2.25.9); fine for PR builds.
hermetic: false — Matches all CUDA runtime PR pipelines; no change needed unless repo policy shifts.
Recommendation
- Close PR [rhoai-2.25] Add pytorch-llmcompressor PR pipeline and FIPS check blocking #2233 with a note that #2355 and RHAIENG-6036 already delivered this on
rhoai-2.25. - Delete branch
add-pr-pipelines-2.25after close to avoid confusion. - No further review or merge work required unless you want to verify Konflux PR builds on
rhoai-2.25directly (/build-runtime-pytorch-llmcompressoron a test PR).
1c4d0d5 to
763378f
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Rebase and push are done. What happened
ResultThe branch now matches If you still need this work tracked, it’s already on |
2 participants
Description
Add pull-request pipeline for pytorch-llmcompressor runtime and add FIPS check blocking parameter to all notebook pull-request pipelines for rhoai-2.25.
Per konflux-central PR #2106, FIPS checks have been disabled for affected notebook
components. This PR updates all pull-request pipelines to reflect that change.
How Has This Been Tested?
Self checklist (all need to be checked):
make test(gmakeon macOS) before asking for reviewDockerfile.konfluxfiles should be done inodh/notebooksand automatically synced torhds/notebooks. For Konflux-specific changes, modifyDockerfile.konfluxfiles directly inrhds/notebooksas these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria:
Summary by CodeRabbit
fips-check-blockingconfiguration parameter (set to"false"by default) across multiple build pipeline definitions, enabling flexible control over FIPS-related build checks.