[rhoai-2.25] RHAIENG-6036: waive codeserver sandbox-runtime seccomp in check-payload

[jiridanek]

Summary

Split from #2487/#2488: add check-payload FIPS waivers for @anthropic-ai/sandbox-runtime apply-seccomp static binaries on codeserver images.

Test plan

• codeserver-ubi9-python-3.12 check-payload green on Build Notebooks matrix

Related

• [rhoai-2.25] RHAIENG-6036: fix trustyai k8s papermill probe timing #2487 — codeserver mysql skip + trustyai Dockerfile/probes
• [rhoai-2.25] RHAIENG-6036: extend OCP port-forward HTTP wait for slow arches #2488 — OCP HTTP wait only

Made with Cursor

Summary by CodeRabbit

• Bug Fixes
  • Improved package validation to correctly recognize additional static sandbox helper binaries.
  • Prevented false-positive cryptographic compliance warnings when validating packages that include these binaries.
  • Ensured validation results more accurately reflect the contents of code-server RPM packages.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f3a2ac9b-046d-4634-af18-96a9756f0f9b

📥 Commits

Reviewing files that changed from the base of the PR and between e8d4179 and b5b12ca.

📒 Files selected for processing (1)

• scripts/check-payload/config.toml

🚧 Files skipped from review as they are similar to previous changes (1)

• scripts/check-payload/config.toml

---

📝 Walkthrough

Walkthrough

Expanded payload checker ignore lists to include static apply-seccomp helper binaries from @anthropic-ai/sandbox-runtime for generic checks and code-server RPM payloads.

Changes

Payload checks

Layer / File(s)	Summary
Seccomp helper ignore lists scripts/check-payload/config.toml	Adds arm64 and x64 apply-seccomp helper paths to both relevant ErrNotDynLinked ignore lists.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: daniellutz

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description includes the change summary and test plan but omits the required testing details and repository checklists.	Add the required Description and How Has This Been Tested sections, complete the self checklist, and record the test result.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the codeserver check-payload waiver for sandbox-runtime seccomp binaries.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/rhoai-2.25-codeserver-fips-waivers

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andyatmiami for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jiridanek]

we should not ignore this, even though we're not FIPS compliant, actually getting those exceptions is more work than taking care of this in some other way

[jiridanek]

/hold for the reasons aboe

[jiridanek]

/build-konflux

[jiridanek]

/build-konflux

[github-actions]

Superseded by newer run: https://github.com/red-hat-data-services/notebooks/actions/runs/30797757977

CI status [antigravity]

Run: Build Notebooks (push) #30797754546 — 2/2 complete · 2 skipped
Last updated: 2026-08-03T08:32:21Z

Workflow completed with skipped jobs.

[github-actions]

CI status [antigravity]

Run: Build Notebooks (pr) #30797757977 — 2/2 complete · 1 passed · 1 skipped
Last updated: 2026-08-03T08:34:21Z

No workbench image jobs ran; all matrix jobs were skipped.

[github-actions]

📋 Review Summary

This PR cleanly adds check-payload waivers for @anthropic-ai/sandbox-runtime static apply-seccomp helper binaries across both dist and vendor paths in scripts/check-payload/config.toml. The additions prevent false-positive validation errors regarding dynamic linking for code-server images.

🔍 General Feedback

• The configuration changes correctly mirror existing exclusion patterns (such as those used for ripgrep) and cover both arm64 and x64 architectures under both dist and root vendor structures.

I did not post inline review comments.

[jiridanek]

/test odh-pipeline-runtime-pytorch-rocm-py312-on-pull-request

[openshift-ci]

@jiridanek: No presubmit jobs available for red-hat-data-services/notebooks@rhoai-2.25

Details

In response to this:

/test odh-pipeline-runtime-pytorch-rocm-py312-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jiridanek]

will not do anything like this, codeserver got handled by vath by upgrading to 4.112 and making the build hermetic-ish and whatever he did, see no fails