Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions .github/actions/free-up-disk-space/action.yml

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/auto-add-issue-to-project.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on: # yamllint disable-line rule:truthy
jobs:
add-to-project:
name: Add issue to projects
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
steps:
- name: Generate github-app token
id: app-token
Expand Down
22 changes: 8 additions & 14 deletions .github/workflows/build-notebooks-TEMPLATE.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -173,23 +173,14 @@ jobs:
- name: Prepare build environment
run: |
set -Eeuxo pipefail
# Match downstream/main: store rootful graphs under /mnt (larger than /).

# opendatahub-io/notebooks#3965; the only promise GitHub gives us
# is >=15GiB disk space on /. In practice, we can either get a single
# volume machine or a two volume machine (with extra volume mounted
# under /mnt. Either case, /mnt should be large enough to fit our images.
sudo mkdir -p /mnt/containers/storage
sudo chown -R "${USER}:${USER}" /mnt/containers/storage

# codeserver npm ci can exhaust 16GB GHA runners during parallel postinstall.
- name: Add swap for codeserver GHA builds
if: ${{ contains(inputs.target, 'codeserver') }}
run: |
set -Eeuxo pipefail
sudo swapoff -a || true
sudo rm -f /swapfile /mnt/swapfile
sudo fallocate -l 16G /swapfile
sudo chmod 600 /swapfile
sudo mkswap /swapfile
sudo swapon /swapfile
free -h

# endregion

# region Podman setup
Expand Down Expand Up @@ -389,6 +380,8 @@ jobs:
- name: "Build: make ${{ inputs.target }}"
id: make-target
run: |
# Print disk and memory stats every 30s so OOM/disk-full failures
# leave a breadcrumb trail in the logs.
uv run scripts/monitor_resources.py &
uv run make ${{ inputs.target }}
env:
Expand All @@ -408,6 +401,7 @@ jobs:
# long builds and check-payload image mounts — run Playwright first.
# https://playwright.dev/docs/ci
# https://playwright.dev/docs/docker
# opendatahub-io/notebooks#3965: podman storage is configured to have sufficient disk space
- name: Run Playwright tests
if: ${{ !cancelled() && contains(inputs.target, 'codeserver') && steps.make-target.outcome == 'success' }}
uses: ./.github/actions/playwright-test
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-notebooks-pr-aipcc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ env:
jobs:
gen:
name: Generate job matrix
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
# rhds/notebooks builds from AIPCC bases and requires pull_request_target trigger
if: ${{ github.repository == 'red-hat-data-services/notebooks' }}
outputs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-notebooks-pr-rhel.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ env:
jobs:
gen:
name: Generate job matrix
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
outputs:
matrix: ${{ steps.gen.outputs.matrix }}
has_jobs: ${{ steps.gen.outputs.has_jobs }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-notebooks-push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ permissions:
jobs:
gen:
name: Generate job matrix
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
# for odh-io/notebooks and rhds/notebooks, allow only main, rhoai-*, release-*
if: ${{ github.event_name == 'workflow_dispatch' ||
(github.repository != 'opendatahub-io/notebooks' && github.repository != 'red-hat-data-services/notebooks')
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/code-quality.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ permissions:

jobs:
check-generated-code:
runs-on: ubuntu-24.04
runs-on: ubuntu-26.04
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
Expand Down Expand Up @@ -45,7 +45,7 @@ jobs:
fi

pytest-tests:
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
Expand Down Expand Up @@ -98,7 +98,7 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}

go-tests:
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
permissions:
contents: read
steps:
Expand Down Expand Up @@ -143,7 +143,7 @@ jobs:
files: scripts/buildinputs/junit-go.xml

code-static-analysis:
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
Expand Down Expand Up @@ -195,7 +195,7 @@ jobs:

action-pin-check:
name: GitHub Actions SHA pinning
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
permissions:
contents: read
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ concurrency:
jobs:
analyze:
name: CodeQL (${{ matrix.language }})
runs-on: ubuntu-24.04
runs-on: ubuntu-26.04
permissions:
contents: read
security-events: write
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/create-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ env:
jobs:
release:
name: Create opendatahub-io/notebooks release
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
steps:
- name: Check out repository
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ env:
jobs:
generate-releasenotes:
name: Generate list of images for release notes
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gitleaks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ concurrency:
jobs:
scan:
name: Gitleaks secret scan
runs-on: ubuntu-24.04
runs-on: ubuntu-26.04
permissions:
contents: read
security-events: write
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/insta-merge.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ permissions:

jobs:
instant-merge:
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
steps:
- name: insta-merge
if: ${{ github.event.sender.login == 'red-hat-konflux[bot]' && ( contains(github.event.pull_request.title, 'Update odh-workbench-jupyter-') || contains(github.event.pull_request.title, 'Update odh-workbench-codeserver-') || contains(github.event.pull_request.title, 'Update odh-pipeline-runtime-') ) }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/instant-merge.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ permissions:

jobs:
instant-merge:
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
steps:
- name: instant-merge
if: ${{ github.event.sender.login == 'red-hat-konflux[bot]' && ( contains(github.event.pull_request.title, 'Update odh-workbench-jupyter-') || contains(github.event.pull_request.title, 'Update odh-workbench-codeserver-') || contains(github.event.pull_request.title, 'Update odh-pipeline-runtime-') ) }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/notebook-digest-updater.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ env:
RELEASE_VERSION_N_1: 2024a
jobs:
initialize:
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
permissions:
contents: write
steps:
Expand All @@ -42,7 +42,7 @@ jobs:

update-n-version:
needs: [initialize]
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
permissions:
contents: write
steps:
Expand Down Expand Up @@ -137,7 +137,7 @@ jobs:

update-n-1-version:
needs: [initialize, update-n-version]
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
permissions:
contents: write
steps:
Expand Down Expand Up @@ -228,7 +228,7 @@ jobs:

open-pull-request:
needs: [update-n-version, update-n-1-version]
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
permissions:
pull-requests: write
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/notebooks-digest-updater.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ env:

jobs:
update-images:
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
permissions:
contents: write
pull-requests: write
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/notebooks-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
# 2. Check if the Manifest PR is merged
Manifests_merged:
needs: Update_manifests
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
outputs:
pr_merged_m: ${{ steps.check_pr.outputs.pr_merged }}
steps:
Expand Down Expand Up @@ -100,7 +100,7 @@ jobs:
BuildConfigs_merged:
needs: Update_buildConfigs
if: ${{ inputs.update_buildconfigs && github.event.inputs.release_type == 'Release' }}
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
outputs:
pr_merged_b: ${{ steps.check_pr.outputs.pr_merged }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/notify-team-to-review-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ permissions:
jobs:
add-label:
if: contains(github.event.pull_request.labels.*.name, 'konflux-nudge') == false
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
steps:

# SECURITY: never clone untrusted code in pull_request_target workflows
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/params-env.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ permissions:

jobs:
validation-of-params-env:
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/piplock-renewal.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ on: # yamllint disable-line rule:truthy

jobs:
refresh-pipfile-locks:
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
concurrency:
group: refresh-pipfile-locks-${{ matrix.python-version }}-${{ github.ref }}
cancel-in-progress: false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-merge-image-delete.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ env:
QUAY_IMAGE_REPO: ${{ secrets.QUAY_IMAGE_REPO }}
jobs:
delete-pr-quay-image:
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
steps:
- name: Git checkout
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/purge-ghcr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ permissions:

jobs:
clean:
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
name: Delete old test images
steps:
# https://github.com/snok/container-retention-policy?tab=readme-ov-file#parameters
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/rpms-lock-renewal.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ jobs:
refresh-rpm-lock-files:
if: github.event_name == 'workflow_dispatch'
# Match build-notebooks-TEMPLATE / install-podman-action (Podman 5.7+).
# ubuntu-latest is still 24.04 and fails the AppArmor pasta peer reload
# (apparmor_parser exits 2 when /etc/apparmor.d/usr.bin.pasta is absent).
# ubuntu-24.04 fails the AppArmor pasta peer reload (apparmor_parser exits 2
# when /etc/apparmor.d/usr.bin.pasta is absent).
runs-on: ubuntu-26.04
concurrency:
group: refresh-rpm-lock-files-${{ github.ref }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/sec-scan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ env:
RELEASE_VERSION_N_1: 2023a
jobs:
initialize:
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
permissions:
contents: write
steps:
Expand All @@ -42,7 +42,7 @@ jobs:

check-vulnerabilities:
needs: [initialize]
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
permissions:
contents: write
steps:
Expand Down Expand Up @@ -123,7 +123,7 @@ jobs:
# Creates the Pull Request
open-pull-request:
needs: [check-vulnerabilities]
runs-on: ubuntu-latest
runs-on: ubuntu-26.04
permissions:
pull-requests: write
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/security.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ name: Security
jobs:
build:
name: Trivy scan (fs)
runs-on: ubuntu-24.04
runs-on: ubuntu-26.04
permissions:
contents: read
security-events: write
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/semgrep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ concurrency:
jobs:
scan:
name: Semgrep scan
runs-on: ubuntu-24.04
runs-on: ubuntu-26.04
permissions:
contents: read
security-events: write
Expand Down
Loading
Loading