Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -33,26 +33,29 @@ spec:
- name: notebook-port
protocol: TCP
containerPort: 8888
# Generous delays for slow or constrained nodes (e.g. ppc64le in CI).
# Liveness must allow Jupyter + datascience deps to bind before first check (avoids restart loops).
livenessProbe:
tcpSocket:
port: notebook-port
initialDelaySeconds: 5
periodSeconds: 5
initialDelaySeconds: 120
periodSeconds: 10
successThreshold: 1
failureThreshold: 3
failureThreshold: 6
readinessProbe:
httpGet:
path: /notebook/opendatahub/jovyan/api
port: notebook-port
scheme: HTTP
initialDelaySeconds: 10
periodSeconds: 5
initialDelaySeconds: 90
periodSeconds: 10
successThreshold: 1
failureThreshold: 3
failureThreshold: 6
# Jupyter + papermill share the pod cgroup; keep headroom for datascience tests on ppc64le CI.
resources:
limits:
cpu: 500m
memory: 2Gi
memory: 4Gi
requests:
cpu: 500m
memory: 2Gi
memory: 4Gi
13 changes: 7 additions & 6 deletions jupyter/minimal/ubi9-python-3.12/kustomize/base/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,22 +33,23 @@ spec:
- name: notebook-port
protocol: TCP
containerPort: 8888
# Generous delays for slow or constrained nodes (e.g. ppc64le in CI)
livenessProbe:
tcpSocket:
port: notebook-port
initialDelaySeconds: 5
periodSeconds: 5
initialDelaySeconds: 30
periodSeconds: 10
successThreshold: 1
failureThreshold: 3
failureThreshold: 6
readinessProbe:
httpGet:
path: /notebook/opendatahub/jovyan/api
port: notebook-port
scheme: HTTP
initialDelaySeconds: 10
periodSeconds: 5
initialDelaySeconds: 45
periodSeconds: 10
successThreshold: 1
failureThreshold: 3
failureThreshold: 6
resources:
limits:
cpu: 500m
Expand Down
5 changes: 3 additions & 2 deletions tests/containers/kubernetes_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -267,11 +267,12 @@ def deploy(

self.port = p.get_actual_port()
LOGGER.debug(f"Listening on port {self.port}")
# Use 120s timeout for slower cold starts (e.g. code-server on arm64).
Wait.until(
"Connecting to pod succeeds",
1,
30,
lambda: requests.get(f"http://localhost:{self.port}").status_code == 200,
120,
lambda: requests.get(f"http://127.0.0.1:{self.port}/api", timeout=10).status_code == 200,
)
LOGGER.debug("Done setting up portforward")

Expand Down
Loading