[rhoai-2.25] chore(.tekton/): remove ODH leftover RStudio push PipelineRuns - #2693
Conversation
…neRuns Delete stale ODH RStudio push PipelineRuns that reference local singlearch-push-pipeline without a remote pipeline annotation. PAC validation on rhoai-2.25 PRs fails with "cannot find referenced pipeline singlearch-push-pipeline", blocking Konflux retrigger. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@jiridanek — This PR is from a fork. Recommended: Push your branch to the main repo for full CI: Then open a new PR from that branch. No push access? A maintainer will cherry-pick and test your changes. See CONTRIBUTING.md for details. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ide-developer The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test pepazdepa |
|
@jiridanek: No presubmit jobs available for red-hat-data-services/notebooks@rhoai-2.25 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThe change deletes two obsolete Tekton Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
445a472
into
red-hat-data-services:rhoai-2.25
Summary
Removes two stale ODH leftover RStudio push PipelineRuns from
.tekton/onrhoai-2.25. This completes an incomplete branch cleanup that was already done onrhoai-3.0throughrhoai-3.5in July 2026.Background —
.tekton/on RHDS release branchesRHDS release branches (
rhoai-2.25,rhoai-3.x, …) carry two generations of Konflux config:Active RHDS release builds —
*-v2-25-push.yaml/*-v3-*-push.yaml, synced fromkonflux-central(pipelineruns/notebooks/.tekton/). These use a git resolver tokonflux-central(pipelines/multi-arch-container-build.yamlon the matching release branch).RHDS PR automation — plain
odh-*-py312-pull-request.yaml(namespacerhoai-tenant,application: automation, images underquay.io/rhoai/pull-request-pipelines). Also git-resolver based.ODH leftovers — older MintMaker/onboarding artifacts that still point at ODH (
namespace: open-data-hub-tenant,quay.io/opendatahub,application: opendatahub-release/opendatahub-builds,target_branch == "main"). They were never part of the RHDSrhoai-*release pipeline set and should not remain on RHDS branches.The
.tekton/README.mdin this repo documents that ongoing Tekton changes for release branches are owned inkonflux-central; these two files are not inkonflux-central’srhoai-2.25sync tree — they are orphaned copies left innotebooks.What was cleaned up elsewhere (but not on
rhoai-2.25)In July 2026, a coordinated cleanup removed ODH leftover PipelineRuns from newer release branches (#2587 … #2596). That sweep deleted RStudio push and pull-request leftovers on branches like
rhoai-3.0, along with other ODH-only push/PR YAMLs.rhoai-2.25was not included in that sweep. Likely reasons:rhoai-2.25uses the older*-v2-25-push.yamlnaming (not*-v3-*), so it was outside the batch scope.After that removal, only the push variants of the ODH RStudio PipelineRuns remained on
rhoai-2.25:odh-workbench-rstudio-minimal-cpu-py312-c9s-push.yamlopen-data-hub-tenant,quay.io/opendatahub,target_branch == "main"odh-workbench-rstudio-minimal-cuda-py312-c9s-push.yamlTheir pull-request counterparts were already absent (removed in the RStudio deprecation work or never synced here).
What this is causing today
Pipelines as Code validates every YAML in
.tekton/when processing a commit — not only the PipelineRuns that match the PR event.These two files reference a local pipeline by name:
There is no
PipelineCR with that name in.tekton/onrhoai-2.25, and there is nopipelinesascode.tekton.dev/pipelineannotation pointing to a remote definition.konflux-centralonrhoai-2.25also has nosinglearch-push-pipeline(onlycontainer-build.yaml,multi-arch-container-build.yaml, etc.).PAC therefore fails before any PipelineRun is applied, with:
User-visible impact
/build-konflux, re-run checks, or new pushes) does not fix it — validation fails on every commit until the stale YAMLs are removed.*-on-pull-requestpipelines may still start on the cluster for the same PR, but the parent Konflux gate stays red and PRs cannot clear Konflux.This PR deletes only the two orphaned ODH RStudio push files. It does not touch:
*-v2-25-push.yaml(active RHDS release builds)odh-*-py312-pull-request.yaml(RHDS PR automation).tekton/README.mdTest plan
rhoai-2.25and confirm Konflux Production Internal no longer reportspipelinerun start failure/singlearch-push-pipeline*-v2-25-push.yamland*-pull-request.yamlRHDS pipelines remain/build-konflux— aggregate Konflux check should pass validationSummary by CodeRabbit