Skip to content

[rhoai-2.25] chore(.tekton/): remove ODH leftover RStudio push PipelineRuns - #2693

Merged
jiridanek merged 1 commit into
red-hat-data-services:rhoai-2.25from
jiridanek:chore/remove-odh-leftover-rstudio-tekton-rhoai-2.25
Aug 3, 2026
Merged

[rhoai-2.25] chore(.tekton/): remove ODH leftover RStudio push PipelineRuns#2693
jiridanek merged 1 commit into
red-hat-data-services:rhoai-2.25from
jiridanek:chore/remove-odh-leftover-rstudio-tekton-rhoai-2.25

Conversation

@jiridanek

@jiridanek jiridanek commented Aug 3, 2026

Copy link
Copy Markdown
Member

Summary

Removes two stale ODH leftover RStudio push PipelineRuns from .tekton/ on rhoai-2.25. This completes an incomplete branch cleanup that was already done on rhoai-3.0 through rhoai-3.5 in July 2026.

Background — .tekton/ on RHDS release branches

RHDS release branches (rhoai-2.25, rhoai-3.x, …) carry two generations of Konflux config:

  1. Active RHDS release builds*-v2-25-push.yaml / *-v3-*-push.yaml, synced from konflux-central (pipelineruns/notebooks/.tekton/). These use a git resolver to konflux-central (pipelines/multi-arch-container-build.yaml on the matching release branch).

  2. RHDS PR automation — plain odh-*-py312-pull-request.yaml (namespace rhoai-tenant, application: automation, images under quay.io/rhoai/pull-request-pipelines). Also git-resolver based.

  3. ODH leftovers — older MintMaker/onboarding artifacts that still point at ODH (namespace: open-data-hub-tenant, quay.io/opendatahub, application: opendatahub-release / opendatahub-builds, target_branch == "main"). They were never part of the RHDS rhoai-* release pipeline set and should not remain on RHDS branches.

The .tekton/README.md in this repo documents that ongoing Tekton changes for release branches are owned in konflux-central; these two files are not in konflux-central’s rhoai-2.25 sync tree — they are orphaned copies left in notebooks.

What was cleaned up elsewhere (but not on rhoai-2.25)

In July 2026, a coordinated cleanup removed ODH leftover PipelineRuns from newer release branches (#2587#2596). That sweep deleted RStudio push and pull-request leftovers on branches like rhoai-3.0, along with other ODH-only push/PR YAMLs.

rhoai-2.25 was not included in that sweep. Likely reasons:

  • rhoai-2.25 uses the older *-v2-25-push.yaml naming (not *-v3-*), so it was outside the batch scope.
  • RStudio workbench images were removed from RHOAI earlier ([#RHAIENG-4776](https://issues.redhat.com/browse/RHAIENG-4776), April 2026 — “remove RStudio workbench images and automation”), but the ODH RStudio Tekton YAMLs were not fully purged from this branch.

After that removal, only the push variants of the ODH RStudio PipelineRuns remained on rhoai-2.25:

File ODH markers
odh-workbench-rstudio-minimal-cpu-py312-c9s-push.yaml open-data-hub-tenant, quay.io/opendatahub, target_branch == "main"
odh-workbench-rstudio-minimal-cuda-py312-c9s-push.yaml same

Their pull-request counterparts were already absent (removed in the RStudio deprecation work or never synced here).

What this is causing today

Pipelines as Code validates every YAML in .tekton/ when processing a commit — not only the PipelineRuns that match the PR event.

These two files reference a local pipeline by name:

pipelineRef:
  name: singlearch-push-pipeline

There is no Pipeline CR with that name in .tekton/ on rhoai-2.25, and there is no pipelinesascode.tekton.dev/pipeline annotation pointing to a remote definition. konflux-central on rhoai-2.25 also has no singlearch-push-pipeline (only container-build.yaml, multi-arch-container-build.yaml, etc.).

PAC therefore fails before any PipelineRun is applied, with:

cannot find referenced pipeline singlearch-push-pipeline. for a remote pipeline make sure to add it in the annotation

User-visible impact

  • The aggregate GitHub check Konflux Production Internal fails immediately with pipelinerun start failure (example: PR #2456 checks).
  • Retriggering Konflux (/build-konflux, re-run checks, or new pushes) does not fix it — validation fails on every commit until the stale YAMLs are removed.
  • Individual *-on-pull-request pipelines may still start on the cluster for the same PR, but the parent Konflux gate stays red and PRs cannot clear Konflux.

This PR deletes only the two orphaned ODH RStudio push files. It does not touch:

  • *-v2-25-push.yaml (active RHDS release builds)
  • odh-*-py312-pull-request.yaml (RHDS PR automation)
  • .tekton/README.md

Test plan

  • After merge, open or update a PR against rhoai-2.25 and confirm Konflux Production Internal no longer reports pipelinerun start failure / singlearch-push-pipeline
  • Confirm *-v2-25-push.yaml and *-pull-request.yaml RHDS pipelines remain
  • Rebase #2456 (or similar) and run /build-konflux — aggregate Konflux check should pass validation

Summary by CodeRabbit

  • Chores
    • Removed obsolete automated pipeline configurations for CPU and CUDA-based RStudio image builds.
    • No end-user-facing functionality was changed.

…neRuns

Delete stale ODH RStudio push PipelineRuns that reference local
singlearch-push-pipeline without a remote pipeline annotation. PAC
validation on rhoai-2.25 PRs fails with "cannot find referenced pipeline
singlearch-push-pipeline", blocking Konflux retrigger.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

@jiridanek — This PR is from a fork.
The build-rhoai CI job was skipped because subscription
builds (RHEL, AIPCC) need secrets unavailable to forks.
ODH builds and code quality checks still ran.

Recommended: Push your branch to the main repo for full CI:

git remote add upstream https://github.com/red-hat-data-services/notebooks.git
git push upstream HEAD:jiridanek/your-branch-name

Then open a new PR from that branch.

No push access? A maintainer will cherry-pick and test your changes.

See CONTRIBUTING.md for details.

@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ide-developer
Once this PR has been reviewed and has the lgtm label, please assign andyatmiami for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the lgtm label Aug 3, 2026
@jiridanek

Copy link
Copy Markdown
Member Author

/test pepazdepa

@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown

@jiridanek: No presubmit jobs available for red-hat-data-services/notebooks@rhoai-2.25

Details

In response to this:

/test pepazdepa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
openshift-ci Bot requested review from atheo89 and daniellutz August 3, 2026 09:15
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f966a4ed-7a39-4a35-b549-c9e40f7f1488

📥 Commits

Reviewing files that changed from the base of the PR and between 763378f and 3b8c5e9.

📒 Files selected for processing (2)
  • .tekton/odh-workbench-rstudio-minimal-cpu-py312-c9s-push.yaml
  • .tekton/odh-workbench-rstudio-minimal-cuda-py312-c9s-push.yaml
💤 Files with no reviewable changes (2)
  • .tekton/odh-workbench-rstudio-minimal-cuda-py312-c9s-push.yaml
  • .tekton/odh-workbench-rstudio-minimal-cpu-py312-c9s-push.yaml

📝 Walkthrough

Walkthrough

The change deletes two obsolete Tekton PipelineRun manifests for RStudio minimal CPU and CUDA workbench images.

Changes

Cohort / File(s) Summary
RStudio PipelineRun removal
.tekton/odh-workbench-rstudio-minimal-cpu-py312-c9s-push.yaml, .tekton/odh-workbench-rstudio-minimal-cuda-py312-c9s-push.yaml
Deletes push trigger annotations, build parameters, pipeline references, service accounts, workspaces, and empty status definitions.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: atheo89, dibryant, ide-developer

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states that stale ODH RStudio push PipelineRuns are being removed from the Tekton configuration.
Description check ✅ Passed The description provides detailed context, identifies the affected files, explains the PAC failure, and includes a specific test plan.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jiridanek
jiridanek merged commit 445a472 into red-hat-data-services:rhoai-2.25 Aug 3, 2026
25 of 26 checks passed
@jiridanek
jiridanek deleted the chore/remove-odh-leftover-rstudio-tekton-rhoai-2.25 branch August 3, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants