fix(s390x): install zeromq-devel from rhelai-3.0 for pyzmq builds by jiridanek · Pull Request #2706 · red-hat-data-services/notebooks

jiridanek · 2026-08-04T20:01:49Z

Summary

On s390x AIPCC bases, subscription-manager refresh then enable rhelai-3.0-for-rhel-9-s390x-rpms and install RH-signed zeromq-devel so pyzmq links system libzmq instead of bundling it under qemu-user emulation.
Applies to runtime and jupyter datascience Dockerfile.konflux.cpu.

Context

Fixes the recurring runtime-datascience-ubi9-python-3.12 · linux/s390x failure (pyzmq bundled libzmq CMake error: ZMQ_CACHELINE_SIZE undefined) seen on PRs such as #2504 and #2694.

All GHA rhoai builds use subscribed AIPCC bases with entitlements mounted — no UBI-only fallback path, so no CFLAGS=-Dundefined=64 merge is needed once zeromq-devel is installed.

Test plan

GHA runtime-datascience-ubi9-python-3.12 · linux/s390x [rhoai] / build passes
Konflux/AIPCC build uses zeromq-devel from rhelai-3.0 and skips bundled libzmq compile
jupyter-datascience-ubi9-python-3.12 · linux/s390x still green

Summary by CodeRabbit

New Features
- Added improved support for s390x CPU image builds.
- Enabled access to the required RHEL AI 3.0 package repository.
- Added ZeroMQ development support to the s390x environment.
Bug Fixes
- Refreshed subscription metadata during image builds to ensure packages are retrieved from current sources.
- Improved package handling to install architecture-specific dependencies reliably.

Enable rhelai-3.0-for-rhel-9-s390x-rpms on AIPCC bases so pyzmq links system libzmq instead of bundling it. Keep -Dundefined=64 as a fallback when zeromq-devel is unavailable on UBI-only GHA builds. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions · 2026-08-04T20:02:09Z

Superseded by newer run: https://github.com/red-hat-data-services/notebooks/actions/runs/30946259763

CI status [antigravity]

Run: Build Notebooks (push) #30945963593 — 2/2 complete · 2 skipped
Last updated: 2026-08-04T20:02:04Z

Workflow completed with skipped jobs.

coderabbitai · 2026-08-04T20:04:43Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1c822ca2-1854-4c0b-bdca-b5862b61bc95

📥 Commits

Reviewing files that changed from the base of the PR and between 213feea and 72345ba.

📒 Files selected for processing (2)

jupyter/datascience/ubi9-python-3.12/Dockerfile.konflux.cpu
runtimes/datascience/ubi9-python-3.12/Dockerfile.konflux.cpu

🚧 Files skipped from review as they are similar to previous changes (2)

runtimes/datascience/ubi9-python-3.12/Dockerfile.konflux.cpu
jupyter/datascience/ubi9-python-3.12/Dockerfile.konflux.cpu

📝 Walkthrough

Walkthrough

The s390x package-installation branches in two UBI9 Python 3.12 CPU Dockerfiles now use Bash arrays, refresh subscription metadata, enable the RHEL AI 3.0 s390x repository, and install zeromq-devel. One obsolete comment was removed.

Changes

s390x build configuration

Layer / File(s)	Summary
s390x repository and dependency setup `jupyter/datascience/ubi9-python-3.12/Dockerfile.konflux.cpu`, `runtimes/datascience/ubi9-python-3.12/Dockerfile.konflux.cpu`	The package branches use arrays and pass packages to `dnf` as separate arguments. The s390x branches refresh subscription metadata, enable the RHEL AI 3.0 s390x repository, and install `zeromq-devel`. The jupyter Dockerfile removes an obsolete comment.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

red-hat-data-services/notebooks#2434: Modifies the same datascience Dockerfile dependency and package-installation logic.
red-hat-data-services/notebooks#2471: Modifies the same jupyter Dockerfile package-installation logic.
red-hat-data-services/notebooks#2555: Updates related RHEL9 Dockerfile repository and dependency handling.

Suggested reviewers: atheo89, dibryant

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains the change and context, but it omits required template sections and provides no completed test results or checklist confirmations.	Add the required Description and How Has This Been Tested sections, report completed test results, and complete all applicable checklist items.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the s390x fix and the addition of zeromq-devel for pyzmq builds.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/s390x-pyzmq-zeromq-devel

_{Comment @coderabbitai help to get the list of available commands.}

Drop the pkg-config CFLAGS fallback; subscribed GHA/AIPCC builds always have entitlements. Use subscription-manager refresh plus repos --enable so dnf can see rhelai-3.0 before installing zeromq-devel. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions · 2026-08-04T20:05:58Z

Superseded by newer run: https://github.com/red-hat-data-services/notebooks/actions/runs/30945978617

CI status [antigravity]

Run: Build Notebooks (push) #30946259763 — 2/2 complete · 2 skipped
Last updated: 2026-08-04T20:05:53Z

Workflow completed with skipped jobs.

github-actions · 2026-08-04T20:06:23Z

Superseded by newer run: https://github.com/red-hat-data-services/notebooks/actions/runs/30946429246

CI status [antigravity]

Run: Build Notebooks (pr) #30945978617 — 5/5 complete · 1 passed · 4 cancelled
Last updated: 2026-08-04T20:06:16Z after workflow update completed

Failures so far

Job	Failed step	Link
runtime-datascience-ubi9-python-3.12 · linux/amd64 [rhoai] / build	Build: make runtime-datascience-ubi9-python-3.12	logs
jupyter-datascience-ubi9-python-3.12 · linux/amd64 [rhoai] / build	Run actions/checkout@`3d3c42e`	logs
runtime-datascience-ubi9-python-3.12 · linux/s390x [rhoai] / build	Install git-crypt	logs
jupyter-datascience-ubi9-python-3.12 · linux/ppc64le [rhoai] / build	Build: make jupyter-datascience-ubi9-python-3.12	logs

Likely root causes

All jobs were cancelled (The operation was canceled.) during execution/checkout/build phases. There are no actual build or test failures; the workflow run itself was aborted or cancelled.

Suggested next steps

Re-run the workflow to verify whether the changes in jupyter/datascience/ubi9-python-3.12/Dockerfile.konflux.cpu and runtimes/datascience/ubi9-python-3.12/Dockerfile.konflux.cpu build successfully.

Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions · 2026-08-04T20:08:09Z

Superseded by newer run: https://github.com/red-hat-data-services/notebooks/actions/runs/30946264673

CI status [antigravity]

Run: Build Notebooks (push) #30946429246 — 2/2 complete · 2 skipped
Last updated: 2026-08-04T20:08:03Z

Workflow completed with skipped jobs.

github-actions · 2026-08-04T20:08:35Z

Superseded by newer run: https://github.com/red-hat-data-services/notebooks/actions/runs/30946433158

CI status [antigravity]

Run: Build Notebooks (pr) #30946264673 — 5/5 complete · 1 passed · 4 cancelled
Last updated: 2026-08-04T20:08:27Z after workflow update completed

Failures so far

Job	Failed step	Link
runtime-datascience-ubi9-python-3.12 · linux/amd64 [rhoai] / build	Run actions/checkout@`3d3c42e`	logs
runtime-datascience-ubi9-python-3.12 · linux/s390x [rhoai] / build	Run actions/checkout@`3d3c42e`	logs
jupyter-datascience-ubi9-python-3.12 · linux/ppc64le [rhoai] / build	Run actions/checkout@`3d3c42e`	logs
jupyter-datascience-ubi9-python-3.12 · linux/amd64 [rhoai] / build	Run actions/checkout@`3d3c42e`	logs

Likely root causes

The build jobs were cancelled during actions/checkout while attempting to fetch submodules (specifically cloning codeserver/ubi9-python-3.12/prefetch-input/code-server and lib/vscode), which led to a conclusion: cancelled state across the matrix jobs.
The evidence is insufficient to attribute the job failures or cancellations to any code changes in the pull request (such as the updates to Dockerfile.konflux.cpu), as the failure occurred during the initial repository checkout and submodule fetching phase rather than during build or compilation steps.

Suggested next steps

Re-run the workflow to check if the cancellation was caused by a transient platform or timeout issue during submodule cloning.

github-actions · 2026-08-05T02:09:42Z

CI status [antigravity]

Run: Build Notebooks (pr) #30946433158 — 5/5 complete · 3 passed · 2 cancelled
Last updated: 2026-08-10T16:00:15Z after workflow update completed

Failures so far

Job	Failed step	Link
jupyter-datascience-ubi9-python-3.12 · linux/ppc64le [rhoai] / build	Build: make jupyter-datascience-ubi9-python-3.12	logs
runtime-datascience-ubi9-python-3.12 · linux/s390x [rhoai] / build	Build: make runtime-datascience-ubi9-python-3.12	logs

Likely root causes

The workflow runs were cancelled (conclusion: cancelled), so the builds did not complete due to cancellation rather than a build or test failure.
In jupyter-datascience-ubi9-python-3.12 · linux/ppc64le [rhoai] / build, the compilation of Apache Arrow / Parquet (_parquet.cpp) was ongoing when cancellation occurred.
In runtime-datascience-ubi9-python-3.12 · linux/s390x [rhoai] / build, the image build was running subscription-manager and dnf package installations as introduced in runtimes/datascience/ubi9-python-3.12/Dockerfile.konflux.cpu when the workflow was cancelled.

Suggested next steps

Re-run the workflow or trigger a new build to verify that the changes in jupyter/datascience/ubi9-python-3.12/Dockerfile.konflux.cpu and runtimes/datascience/ubi9-python-3.12/Dockerfile.konflux.cpu complete successfully without manual cancellation.

jiridanek · 2026-08-05T10:40:13Z

/build-konflux

jiridanek · 2026-08-10T09:58:14Z

/test odh-pipeline-runtime-pytorch-rocm-py312-on-pull-request

openshift-ci · 2026-08-10T09:58:17Z

@jiridanek: No presubmit jobs available for red-hat-data-services/notebooks@rhoai-2.25

Details

In response to this:

/test odh-pipeline-runtime-pytorch-rocm-py312-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jiridanek · 2026-08-10T09:58:24Z

/test odh-pipeline-runtime-tensorflow-rocm-py312-on-pull-request

openshift-ci · 2026-08-10T09:58:27Z

@jiridanek: No presubmit jobs available for red-hat-data-services/notebooks@rhoai-2.25

Details

In response to this:

/test odh-pipeline-runtime-tensorflow-rocm-py312-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jiridanek · 2026-08-10T09:58:34Z

/test odh-workbench-jupyter-tensorflow-rocm-py312-on-pull-request

openshift-ci · 2026-08-10T09:58:38Z

@jiridanek: No presubmit jobs available for red-hat-data-services/notebooks@rhoai-2.25

Details

In response to this:

/test odh-workbench-jupyter-tensorflow-rocm-py312-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-08-12T07:37:07Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ide-developer
Once this PR has been reviewed and has the lgtm label, please assign atheo89 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci Bot requested review from atheo89 and dibryant August 4, 2026 20:01

github-actions Bot added the review-requested label Aug 4, 2026

refactor(s390x): use bash arrays for PACKAGES in datascience Dockerfiles

72345ba

Co-authored-by: Cursor <cursoragent@cursor.com>

ide-developer approved these changes Aug 12, 2026

View reviewed changes

openshift-ci Bot assigned ide-developer Aug 12, 2026

openshift-ci Bot added the lgtm label Aug 12, 2026

jiridanek merged commit 4f37e8a into rhoai-2.25 Aug 12, 2026
80 of 90 checks passed

jiridanek deleted the fix/s390x-pyzmq-zeromq-devel branch August 12, 2026 07:37

Uh oh!

Conversation

jiridanek commented Aug 4, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Context

Test plan

Summary by CodeRabbit

Uh oh!

github-actions Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI status [antigravity]

Uh oh!

coderabbitai Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI status [antigravity]

Uh oh!

github-actions Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI status [antigravity]

Failures so far

Likely root causes

Suggested next steps

Uh oh!

github-actions Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI status [antigravity]

Uh oh!

github-actions Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI status [antigravity]

Failures so far

Likely root causes

Suggested next steps

Uh oh!

github-actions Bot commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI status [antigravity]

Failures so far

Likely root causes

Suggested next steps

Uh oh!

jiridanek commented Aug 5, 2026

Uh oh!

jiridanek commented Aug 10, 2026

Uh oh!

openshift-ci Bot commented Aug 10, 2026

Uh oh!

jiridanek commented Aug 10, 2026

Uh oh!

openshift-ci Bot commented Aug 10, 2026

Uh oh!

jiridanek commented Aug 10, 2026

Uh oh!

openshift-ci Bot commented Aug 10, 2026

Uh oh!

openshift-ci Bot commented Aug 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jiridanek commented Aug 4, 2026 •

edited by coderabbitai Bot

Loading

github-actions Bot commented Aug 4, 2026 •

edited

Loading

coderabbitai Bot commented Aug 4, 2026 •

edited

Loading

github-actions Bot commented Aug 4, 2026 •

edited

Loading

github-actions Bot commented Aug 4, 2026 •

edited

Loading

github-actions Bot commented Aug 4, 2026 •

edited

Loading

github-actions Bot commented Aug 4, 2026 •

edited

Loading

github-actions Bot commented Aug 5, 2026 •

edited

Loading