Skip to content

[rhoai-3.3] RHAIENG-5305, RHAIENG-5303: fix(cve): CVE-2026-44432, CVE-2026-44431 - update urllib3 to 2.7.0 - #2708

Merged
mtchoum1 merged 2 commits into
red-hat-data-services:rhoai-3.3from
mtchoum1:fix/cve-urllib3-rhoai-3.3
Aug 14, 2026
Merged

[rhoai-3.3] RHAIENG-5305, RHAIENG-5303: fix(cve): CVE-2026-44432, CVE-2026-44431 - update urllib3 to 2.7.0#2708
mtchoum1 merged 2 commits into
red-hat-data-services:rhoai-3.3from
mtchoum1:fix/cve-urllib3-rhoai-3.3

Conversation

@mtchoum1

@mtchoum1 mtchoum1 commented Aug 4, 2026

Copy link
Copy Markdown

Summary

  • CVE-2026-44432: DoS via excessive HTTP response decompression (CVSS 7.5) — urllib3 could decompress entire responses instead of requested portions during successive read(amt=N) calls with Brotli, causing excessive CPU and memory usage
  • CVE-2026-44431: Information disclosure via cross-origin redirects forwarding sensitive headers (CVSS 5.3) — when using ProxyManager.connection_from_url().urlopen() with assert_same_host=False, urllib3 followed cross-origin redirects without stripping Authorization and Cookie headers
  • Both CVEs fixed in urllib3 >= 2.7.0

Changes

  • Add urllib3>=2.7.0 constraint to dependencies/cve-constraints.txt
  • Update odh-notebooks-meta-runtime-elyra-deps urllib3 pin from ~=2.6.0 to ~=2.7.0 (was capping at <2.7.0)
  • Regenerate affected pylock.toml files

Jira Tickets

Test plan

  • make refresh-lock-files succeeds for all images (3 pre-existing failures unrelated to this change: trustyai, rocm-tensorflow)
  • urllib3 resolved to 2.7.0 in all regenerated lock files
  • CI/CD build passes
  • Konflux builds pass

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Addressed security vulnerabilities affecting Python-based environments.
    • Updated the networking library, urllib3, to version 2.7.0 or newer.
  • Chores

    • Refreshed package locks across notebook and runtime environments.
    • Updated dependency constraints and verified package integrity metadata for supported Python 3.12 environments.

@openshift-ci
openshift-ci Bot requested review from daniellutz and jiridanek August 4, 2026 20:49
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

@mtchoum1 — This PR is from a fork.
The build-rhoai CI job was skipped because subscription
builds (RHEL, AIPCC) need secrets unavailable to forks.
ODH builds and code quality checks still ran.

Recommended: Push your branch to the main repo for full CI:

git remote add upstream https://github.com/red-hat-data-services/notebooks.git
git push upstream HEAD:mtchoum1/your-branch-name

Then open a new PR from that branch.

No push access? A maintainer will cherry-pick and test your changes.

See CONTRIBUTING.md for details.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c3c93e81-acf0-4fe7-b01f-bfa9a2188b1d

📥 Commits

Reviewing files that changed from the base of the PR and between 742960e and dd69da5.

📒 Files selected for processing (11)
  • dependencies/cve-constraints.txt
  • dependencies/odh-notebooks-meta-runtime-elyra-deps/pyproject.toml
  • jupyter/datascience/ubi9-python-3.12/pylock.toml
  • jupyter/minimal/ubi9-python-3.12/pylock.toml
  • runtimes/datascience/ubi9-python-3.12/pylock.toml
  • runtimes/minimal/ubi9-python-3.12/pylock.toml
  • runtimes/pytorch+llmcompressor/ubi9-python-3.12/pylock.toml
  • runtimes/pytorch/ubi9-python-3.12/pylock.toml
  • runtimes/rocm-pytorch/ubi9-python-3.12/pylock.toml
  • runtimes/rocm-tensorflow/ubi9-python-3.12/pylock.toml
  • runtimes/tensorflow/ubi9-python-3.12/pylock.toml

📝 Walkthrough

Walkthrough

The PR adds CVE references and raises urllib3 constraints to version 2.7.0. It updates Jupyter and runtime Python 3.12 lockfiles with the new package artifacts and hashes.

Changes

urllib3 CVE refresh

Layer / File(s) Summary
Dependency constraints
dependencies/cve-constraints.txt, dependencies/odh-notebooks-meta-runtime-elyra-deps/pyproject.toml
The constraints document two CVEs and require the urllib3 2.7.x release line.
Jupyter lockfile updates
jupyter/*/ubi9-python-3.12/pylock.toml
The Jupyter lockfiles update urllib3 from 2.6.3 to 2.7.0 and refresh artifact metadata and hashes.
Runtime lockfile updates
runtimes/*/ubi9-python-3.12/pylock.toml
The runtime lockfiles update urllib3 to 2.7.0 and refresh source and wheel metadata and hashes.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🔵 Low · up to dd69d

The PR updates urllib3 constraints, dependency pins, and regenerated lockfiles to address the listed vulnerabilities. Merge readiness is low risk, with explicit owner follow-up needed to confirm the Elyra resolution and lockfile-generation workflow; no concrete product or runtime defect is currently identified.

Possibly related PRs

Suggested reviewers: jiridanek

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the CVE fixes and the urllib3 update to version 2.7.0.
Description check ✅ Passed The description provides a detailed summary, linked Jira tickets, changes, and test results, but it omits the template checklists and leaves build validation pending.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Aug 4, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (rhoai-3.3@742960e). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             rhoai-3.3   #2708   +/-   ##
===========================================
  Coverage             ?       0           
===========================================
  Files                ?       0           
  Lines                ?       0           
  Branches             ?       0           
===========================================
  Hits                 ?       0           
  Misses               ?       0           
  Partials             ?       0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jiridanek

Copy link
Copy Markdown
Member

@coderabbitai resolve merge conflict

Please intelligently resolve the conflicts on this PR branch against rhoai-3.3 (now includes #2757). Prefer keeping this PR's intended CVE/fix changes while taking the base-branch Python 3.12 environment narrowing and related lockfile/constraint updates where they are the upstream fix.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

An unexpected error occurred while resolving merge conflicts:

Not Found - https://docs.github.com/rest/git/refs#get-a-reference

…- update urllib3 to 2.7.0

CVE-2026-44432: DoS via excessive HTTP response decompression (CVSS 7.5)
CVE-2026-44431: Information disclosure via cross-origin redirects (CVSS 5.3)

- Add urllib3>=2.7.0 constraint to dependencies/cve-constraints.txt
- Update odh-notebooks-meta-runtime-elyra-deps urllib3 pin from ~=2.6.0 to ~=2.7.0
- Regenerate affected pylock.toml files

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@jiridanek
jiridanek force-pushed the fix/cve-urllib3-rhoai-3.3 branch from bbca64a to dd69da5 Compare August 14, 2026 07:20
@jiridanek

Copy link
Copy Markdown
Member

/build-konflux

@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtchoum1
mtchoum1 merged commit 7604988 into red-hat-data-services:rhoai-3.3 Aug 14, 2026
39 of 58 checks passed
@mtchoum1
mtchoum1 deleted the fix/cve-urllib3-rhoai-3.3 branch August 14, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants