NO-JIRA: fix(ci): build Playwright browser-tests image on rhoai-3.4 by jiridanek · Pull Request #2744 · red-hat-data-services/notebooks

jiridanek · 2026-08-12T11:22:29Z

Summary

Backport the missing Build browser tests image step from opendatahub-io/notebooks#4096 / rhoai-3.5 into rhoai-3.4's build-notebooks-TEMPLATE.yaml.
Pass playwright-image (and junit-artifact-file) into the composite action that already requires it after PR #2545.
Fixes the codeserver CI failure seen on PR #2699: empty PLAYWRIGHT_IMAGE → podman inspect '' → json: cannot unmarshal array into Go value of type define.InspectContainerData.

Test plan

https://github.com/red-hat-data-services/notebooks/actions/runs/31592576281

Codeserver GHA jobs build localhost/workbench-images-tests:ci before Playwright
Playwright verify step no longer hits Podman unmarshalling error
Non-codeserver targets unchanged (browser-tests-image step is gated on codeserver)

Made with Cursor

Summary by CodeRabbit

Tests
- Improved browser test execution reliability by validating the required test environment before running tests.
- Added automated JUnit test results alongside existing reports, making test outcomes easier to review and troubleshoot.
- Standardized browser testing across codeserver builds using the detected Playwright version.

Backport the browser-tests-image step from opendatahub-io#4096 so codeserver Playwright runs pass the required playwright-image input. Without it PLAYWRIGHT_IMAGE is empty and podman inspect fails with a Go JSON unmarshalling error. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions · 2026-08-12T11:22:48Z

Superseded by newer run: https://github.com/red-hat-data-services/notebooks/actions/runs/31591554770

CI status [antigravity]

Run: Build Notebooks (push) #31591543046 — 3/3 complete · 3 skipped
Last updated: 2026-08-12T11:22:43Z

No workbench image jobs ran; all matrix jobs were skipped.

coderabbitai · 2026-08-12T11:22:58Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d5b49873-1cbd-4953-b480-a89b6f9e86ef

📥 Commits

Reviewing files that changed from the base of the PR and between 7b0cd0e and e070627.

📒 Files selected for processing (1)

.github/workflows/build-notebooks-TEMPLATE.yaml

📝 Walkthrough

Walkthrough

The workflow builds a dedicated Playwright image for successful codeserver builds. Playwright tests use the generated image and upload a platform- and build-type-specific JUnit artifact.

Changes

Playwright workflow

Layer / File(s)	Summary
Build Playwright test image `.github/workflows/build-notebooks-TEMPLATE.yaml`	The workflow derives the Playwright version, builds `tests/browser/Dockerfile`, tags the local image, and exports its reference.
Run tests with image and JUnit output `.github/workflows/build-notebooks-TEMPLATE.yaml`	Playwright execution requires the image build, passes the image to the test action, and configures the JUnit artifact filename.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

red-hat-data-services/notebooks#2452: Both PRs modify the notebook build workflow, but they change different steps and logic.

Suggested labels: lgtm

Suggested reviewers: ysok

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Branch Prefix Policy	⚠️ Warning	Base branch is rhoai-3.4, but the PR title is "NO-JIRA: fix(ci): build Playwright browser-tests image on rhoai-3.4" and lacks the required prefix.	Rename the PR title to start with "[rhoai-3.4] ", for example: "[rhoai-3.4] NO-JIRA: fix(ci): build Playwright browser-tests image".

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title uses imperative mood, includes NO-JIRA, follows the preferred format, and accurately describes the CI change.
Description check	✅ Passed	The description clearly explains the change and provides a relevant test plan, but it does not reproduce or complete the template checklists.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/rhoai-3.4-playwright-browser-tests-image

✨ Simplify code

Create PR with simplified code
Commit simplified code in branch fix/rhoai-3.4-playwright-browser-tests-image

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-12T11:23:51Z

CI status [antigravity]

Run: Build Notebooks (pr) #31591554770 — 3/3 complete · 1 passed · 2 skipped
Last updated: 2026-08-12T11:23:46Z

No workbench image jobs ran; all matrix jobs were skipped.

github-actions · 2026-08-12T11:24:08Z

📋 Review Summary

This PR cleanly backports the Build browser tests image step and Playwright test parameters into rhoai-3.4's workflow template, resolving the empty PLAYWRIGHT_IMAGE podman unmarshalling issue for codeserver builds. The changes are correct, follow established patterns from upstream/other branches, and require no additional inline comments.

🔍 General Feedback

The backport correctly targets codeserver builds and leverages the version detection script appropriately.
Passing playwright-image and junit-artifact-file ensures consistent behavior with upstream PRs.

I did not post inline review comments.

jiridanek

@coderabbitai review summary

Overview: Faithful backport of the Build browser tests image step from rhoai-3.5/upstream opendatahub-io/notebooks#4096 into rhoai-3.4's build-notebooks-TEMPLATE.yaml, plus wiring playwright-image (now required: true on the composite action since #2545) and junit-artifact-file into the playwright-test action call.

Verification performed

Diffed the new block line-by-line against the equivalent section in rhoai-3.5's build-notebooks-TEMPLATE.yaml — byte-identical aside from extra explanatory comments justifying the backport.
Confirmed scripts/get_playwright_version.py and tests/browser/Dockerfile exist on this branch.
Confirmed .github/actions/playwright-test/action.yml requires playwright-image and consumes junit-artifact-file — both are now supplied, matching the described podman inspect '' failure mode this PR fixes.
Checked for id: collisions in the file — browser-tests-image is unique.
CI: Test Template with Minimal Notebook / rhoai passed (12m26s); no failing checks. tide is blocked only on the approved label (process gate, not a code issue).

Verdict: Clean, minimal, correct backport. No correctness, security, or convention issues found. See inline notes below for confirmation points (informational only, no changes requested).

jiridanek · 2026-08-13T20:58:05Z

+      # Backport of opendatahub-io/notebooks#4096: playwright-test requires playwright-image;
+      # without this step PLAYWRIGHT_IMAGE is empty and `podman inspect ''` fails with
+      # "json: cannot unmarshal array into Go value of type define.InspectContainerData".
+      - name: Build browser tests image


Confirmed: this step's build invocation (podman build --build-arg PLAYWRIGHT_VERSION=... -t localhost/workbench-images-tests:ci -f tests/browser/Dockerfile tests/browser) matches build-browser-tests.yaml and the equivalent step in rhoai-3.5's template byte-for-byte. scripts/get_playwright_version.py and tests/browser/Dockerfile both exist on this branch.

jiridanek · 2026-08-13T20:58:05Z

+          echo "image=${IMAGE}" >> "$GITHUB_OUTPUT"
+
+      - name: Run Playwright tests
+        if: ${{ !cancelled() && contains(inputs.target, 'codeserver') && steps.make-target.outcome == 'success' && steps.browser-tests-image.outcome == 'success' }}


Good belt-and-suspenders guard: gating on steps.browser-tests-image.outcome == 'success' in addition to the existing contains(inputs.target, 'codeserver') check ensures Run Playwright tests never executes with an empty playwright-image — which was the root cause of the podman inspect '' failure this PR fixes.

jiridanek · 2026-08-13T20:58:05Z

        uses: ./.github/actions/playwright-test
        with:
          test-target: ${{ steps.calculated_vars.outputs.OUTPUT_IMAGE }}
+          playwright-image: ${{ steps.browser-tests-image.outputs.image }}


Verified: playwright-image is required: true on .github/actions/playwright-test/action.yml since #2545, so this input was indeed missing before this fix. No other callers of this composite action in the repo were left unpatched (checked).

ide-developer

LGTM

openshift-ci · 2026-08-13T21:23:12Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ide-developer
Once this PR has been reviewed and has the lgtm label, please assign atheo89 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci Bot requested review from daniellutz and ysok August 12, 2026 11:22

github-actions Bot added the review-requested label Aug 12, 2026

ide-developer approved these changes Aug 12, 2026

View reviewed changes

openshift-ci Bot assigned ide-developer Aug 12, 2026

openshift-ci Bot added the lgtm label Aug 12, 2026

jiridanek commented Aug 13, 2026

View reviewed changes

ide-developer approved these changes Aug 13, 2026

View reviewed changes

jiridanek merged commit ed6eb51 into rhoai-3.4 Aug 13, 2026
132 of 151 checks passed

jiridanek deleted the fix/rhoai-3.4-playwright-browser-tests-image branch August 13, 2026 21:31

Navigation Menu

Uh oh!

NO-JIRA: fix(ci): build Playwright browser-tests image on rhoai-3.4 - #2744

NO-JIRA: fix(ci): build Playwright browser-tests image on rhoai-3.4#2744
jiridanek merged 1 commit into
rhoai-3.4from
fix/rhoai-3.4-playwright-browser-tests-image

jiridanek commented Aug 12, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 12, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 12, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Aug 12, 2026

Uh oh!

github-actions Bot commented Aug 12, 2026

Uh oh!

jiridanek left a comment

Uh oh!

jiridanek Aug 13, 2026

Uh oh!

jiridanek Aug 13, 2026

Uh oh!

jiridanek Aug 13, 2026

Uh oh!

ide-developer left a comment

Uh oh!

openshift-ci Bot commented Aug 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jiridanek commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

github-actions Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI status [antigravity]

Uh oh!

coderabbitai Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Aug 12, 2026

CI status [antigravity]

Uh oh!

github-actions Bot commented Aug 12, 2026

📋 Review Summary

🔍 General Feedback

Uh oh!

jiridanek left a comment

Choose a reason for hiding this comment

Uh oh!

jiridanek Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

jiridanek Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

jiridanek Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

ide-developer left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Aug 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jiridanek commented Aug 12, 2026 •

edited

Loading

github-actions Bot commented Aug 12, 2026 •

edited

Loading

coderabbitai Bot commented Aug 12, 2026 •

edited

Loading