Skip to content

Regenerate minimal CPU lockfile hashes against the RHAI index - #2774

Open
KorneAlex wants to merge 1 commit into
red-hat-data-services:rhoai-3.6-ea.1from
KorneAlex:fix-minimal-cpu-prefetch-hashes
Open

Regenerate minimal CPU lockfile hashes against the RHAI index#2774
KorneAlex wants to merge 1 commit into
red-hat-data-services:rhoai-3.6-ea.1from
KorneAlex:fix-minimal-cpu-prefetch-hashes

Conversation

@KorneAlex

@KorneAlex KorneAlex commented Aug 19, 2026

Copy link
Copy Markdown

Description

How Has This Been Tested?

Self checklist (all need to be checked):

  • Ensure that you have run make test (gmake on macOS) before asking for review
  • Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

  • Maintenance
    • Refreshed the Python 3.12 CPU runtime package set and lock data.
    • Updated several included tools and libraries to newer patch releases.
    • Regenerated package integrity records and platform-specific installation metadata.
    • No packages were added or removed, and the configured package source remains unchanged.

@openshift-ci
openshift-ci Bot requested review from atheo89 and ayush17 August 19, 2026 16:26
@openshift-ci

openshift-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jiridanek for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown

@KorneAlex — This PR is from a fork.
The build-rhoai CI job was skipped because subscription
builds (RHEL, AIPCC) need secrets unavailable to forks.
ODH builds and code quality checks still ran.

Recommended: Push your branch to the main repo for full CI:

git remote add upstream https://github.com/red-hat-data-services/notebooks.git
git push upstream HEAD:KorneAlex/your-branch-name

Then open a new PR from that branch.

No push access? A maintainer will cherry-pick and test your changes.

See CONTRIBUTING.md for details.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 67d9cf4c-6668-4a2c-824e-da52e1e0333d

📥 Commits

Reviewing files that changed from the base of the PR and between a168697 and a3d4b3d.

📒 Files selected for processing (2)
  • runtimes/minimal/ubi9-python-3.12/requirements.cpu.txt
  • runtimes/minimal/ubi9-python-3.12/uv.lock.d/pylock.cpu.toml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Python 3.12 CPU dependency requirements were refreshed. Five packages received version updates. Existing package hashes and generated wheel metadata were regenerated in the corresponding uv lockfile.

Changes

CPU dependency refresh

Layer / File(s) Summary
Refresh pinned requirements
runtimes/minimal/ubi9-python-3.12/requirements.cpu.txt
Updated hashes for pinned packages and versions for nbformat, platformdirs, soupsieve, tornado, and uv.
Regenerate uv lock records
runtimes/minimal/ubi9-python-3.12/uv.lock.d/pylock.cpu.toml
Updated the --exclude-newer timestamp and regenerated package wheel URLs, metadata, sizes, and hashes.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to a3d4b

This localized lockfile regeneration is merge-ready after normal checks and review, with no actionable merge-blocking risk remaining.

Possibly related PRs

Suggested labels: automated-full-lockfile-renewal

Suggested reviewers: atheo89, ayush17

🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description contains only the template and provides no change details, testing information, or completed checklist items. Add a detailed change summary, testing instructions and results, and mark applicable checklist items after completing them.
Branch Prefix Policy ⚠️ Warning Base is rhoai-3.6-ea.1, but the title is "Regenerate minimal CPU lockfile hashes against the RHAI index" and has no required branch prefix. Expected prefix: [rhoai-3.6-ea.1] . Fix the title by adding this exact prefix.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title uses imperative mood, has no trailing period, and accurately describes the lockfile hash regeneration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant