fix: add missing demo-mode fixtures for field-options and readiness - #1524
Conversation
Add jiraTeam field-options fixture to fix the Capacity Commitment report in demo mode — fetchFieldOptions was 404ing on jiraTeam and poisoning the top-level error state, hiding the entire report UI. Add release-readiness fixtures for rhoai-3.5.EA1 and rhoai-3.6.EA1 to enable multi-version/multi-phase testing in demo mode. Fixes red-hat-data-services#1522 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Claude finished @deekay2310's task in 2m 44s —— View job PR Review: fix: add missing demo-mode fixtures for field-options and readiness
Review SummaryVerdict: Looks good. The fixture files are well-structured and consistent with existing patterns. No blocking issues found. Detailed FindingsFixtures (3 new files) — All Good The The Both new release-readiness fixtures include the
This file's header (line 3) says "DO NOT EDIT MANUALLY — regenerated by Also, this change isn't mentioned in the PR description. Consider documenting it for reviewers. Hard Constraints Check — All Clear
Integration Tests — Not Required No module views, components, or server routes were modified. Fixture-only changes are explicitly exempted per review policy. This was a read-only review (fork PR) — no autofixes were applied. |
| 'releases/reports/tv-fv-delta': 'Dimitri Saridakis', | ||
|
|
||
| // team-tracker > reports | ||
| 'team-tracker/reports/allocation': 'Alex Corvin', |
There was a problem hiding this comment.
Nit: This file's header says "DO NOT EDIT MANUALLY — regenerated by scripts/update-view-owners.js". Consider running npm run update:view-owners instead, or adding this entry to data/view-owner-overrides.json so it survives the next regeneration.
db57294
Summary
jiraTeam.jsonfixture so the Capacity Commitment report renders in demo mode instead of showing "field option set not found" errorrhoai-3.5.EA1.jsonandrhoai-3.6.EA1.jsonrelease-readiness fixtures so the new multi-select filter (feat(releases): replace readiness version dropdown with 3-tier selector #1521) has multiple versions/phases to demonstrateFixes #1522
Test plan
DEMO_MODE=true npm run dev:fulland open Capacity Commitment report — confirm it loads without errors🤖 Generated with Claude Code