Skip to content

fix: add missing demo-mode fixtures for field-options and readiness - #1524

Merged
accorvin merged 1 commit into
red-hat-data-services:mainfrom
deekay2310:fix/demo-mode-fixtures
Sep 4, 2026
Merged

fix: add missing demo-mode fixtures for field-options and readiness#1524
accorvin merged 1 commit into
red-hat-data-services:mainfrom
deekay2310:fix/demo-mode-fixtures

Conversation

@deekay2310

@deekay2310 deekay2310 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #1522

Test plan

  • Run DEMO_MODE=true npm run dev:full and open Capacity Commitment report — confirm it loads without errors
  • Open Release Readiness Director — confirm selector shows multiple versions (3.5, 3.6) and phases (EA1, EA2)

🤖 Generated with Claude Code

Add jiraTeam field-options fixture to fix the Capacity Commitment report
in demo mode — fetchFieldOptions was 404ing on jiraTeam and poisoning
the top-level error state, hiding the entire report UI.

Add release-readiness fixtures for rhoai-3.5.EA1 and rhoai-3.6.EA1 to
enable multi-version/multi-phase testing in demo mode.

Fixes red-hat-data-services#1522

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Claude finished @deekay2310's task in 2m 44s —— View job


PR Review: fix: add missing demo-mode fixtures for field-options and readiness

  • Gather context (diff, review instructions, project conventions)
  • Review changed files against project conventions
  • Post review findings

Review Summary

Verdict: Looks good. The fixture files are well-structured and consistent with existing patterns. No blocking issues found.

Detailed Findings

Fixtures (3 new files) — All Good

The jiraTeam.json field-options fixture matches the documented schema in docs/DATA-FORMATS.md (lines 517–536) exactly. The two release-readiness fixtures (rhoai-3.5.EA1.json, rhoai-3.6.EA1.json) are structurally consistent with the existing rhoai-3.5.EA2.json fixture and provide good demo variety — EA1 is a fully completed release (100%) while 3.6.EA1 is in early planning (25%), which exercises different UI states.

The rhoai-3.6.EA1.json ModelServing and Dashboard tiles intentionally omit the execution field. This is safe — the component guards with v-if="tile.component === 'TestOps' && tile.execution" (ReleaseReadinessDirector.vue:328) and uses optional chaining elsewhere (tile.execution?.done_pct || 0 at line 763).

Both new release-readiness fixtures include the release_schedule field, which is actively read by the server (routes.js:153) and client (ReleaseReadinessDirector.vue:528). The existing EA2 fixture on main is actually missing this field — so these new fixtures are more complete than the existing one.

platform/view-owners/owners.js — Minor Concern (non-blocking)

This file's header (line 3) says "DO NOT EDIT MANUALLY — regenerated by scripts/update-view-owners.js". The PR manually adds 'team-tracker/reports/allocation': 'Alex Corvin'. The allocation report exists as a platform extension (platform/allocation/client/reports/AllocationReport.vue), so the entry is valid — but ideally it should be added by re-running the generation script (npm run update:view-owners) or via data/view-owner-overrides.json rather than editing the generated file directly.

Also, this change isn't mentioned in the PR description. Consider documenting it for reviewers.

Hard Constraints Check — All Clear

Constraint Status
No cross-module imports N/A — fixture data only
Storage abstractions N/A — no data access code
No TypeScript JSON + JS only
OpenAPI annotations N/A — no new routes
Documentation in sync No format changes introduced — release_schedule gap in DATA-FORMATS.md predates this PR
Module secrets via context N/A

Integration Tests — Not Required

No module views, components, or server routes were modified. Fixture-only changes are explicitly exempted per review policy.


This was a read-only review (fork PR) — no autofixes were applied.

'releases/reports/tv-fv-delta': 'Dimitri Saridakis',

// team-tracker > reports
'team-tracker/reports/allocation': 'Alex Corvin',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This file's header says "DO NOT EDIT MANUALLY — regenerated by scripts/update-view-owners.js". Consider running npm run update:view-owners instead, or adding this entry to data/view-owner-overrides.json so it survives the next regeneration.

@accorvin
accorvin added this pull request to the merge queue Sep 4, 2026
Merged via the queue into red-hat-data-services:main with commit db57294 Sep 4, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix: Capacity Commitment report broken in demo mode — jiraTeam field option set missing

2 participants