Skip to content

Conversation

@ijabz
Copy link

@ijabz ijabz commented Mar 9, 2020

Added Release.status

def build_entity(self, entity_id, element):
release = Release()
release.id = entity_id
setattr(release,'status',element.get('status'))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setattr(release,'status',element.get('status'))
setattr(release, 'status', element.get('status'))

@redapple
Copy link
Owner

Thanks @ijabz .
I suggest you make the change on the schema directly on speedup/sql/CreateTables.sql.
I don't see the need for the new speedup/sql/AlterTables.sql

Also, I believe the other changes to primary keys and indices would be better in another PR.
Lets keep this PR on adding back release status.

@ijabz
Copy link
Author

ijabz commented Mar 12, 2020

It wasn't meant to be part of this pull request, this was by accident as I am not that used to using git.
In order to make changes to CreateTables.sql I have would also need to change python code , I have now done this as part for the commit in made to philipmat/discogs-xml2db. Im now running against my version of philipmat/discogs-xml2db since I can commit directly to that repo so I leave these pull requests for you to do with as you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants