Skip to content

Fix token validation error logging on expired tokens #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Fix token validation error logging on expired tokens #29

wants to merge 2 commits into from

Conversation

@ben-mays-rdt
Copy link

@ben-mays-rdt ben-mays-rdt commented May 21, 2025

💸 TL;DR

Reduces log spam for expired token validation. This is a non-exceptional case and we shouldn't log an error.

📜 Details

🧪 Testing Steps / Validation

Added unit test to ensure ValidateJWT will return jwt.ErrTokenExpired. Note, we don't have a way to assert on log output.

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • x ] Contributor License Agreement (CLA) completed if not a Reddit employee

@ben-mays-rdt ben-mays-rdt requested a review from pacejackson May 21, 2025 18:35
pacejackson
pacejackson requested changes May 21, 2025
View reviewed changes
Copy link
Contributor

@pacejackson pacejackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually not sure that expired tokens should be considered "non-exceptional"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pacejackson pacejackson pacejackson requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ben-mays-rdt @pacejackson