Skip to content

Fix build with Docker Desktop on Windows#15

Open
MuellerKlaus wants to merge 1 commit intoreddit:mainfrom
MuellerKlaus:fixdockerwindows
Open

Fix build with Docker Desktop on Windows#15
MuellerKlaus wants to merge 1 commit intoreddit:mainfrom
MuellerKlaus:fixdockerwindows

Conversation

@MuellerKlaus
Copy link
Copy Markdown

Automatic line conversion makes sha256sum fail if build on Windows

💸 TL;DR

sha256sum fails to run if project checked out from Windows with automatic line ending conversion. The change mark the 'checksums.txt' file as non-text.

📜 Details

N/A

🧪 Testing Steps / Validation

  • checkout repo on Windows system with git
  • try to run 'docker build --progress plain .'
  • build fails with 'sha256sum: checksums.txt: no file was verified'
  • build succeed after set git attributes

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

Automatic line conversion makes sha256sum fail if build on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant