Skip to content

Patch: Address Failing Check and Add Config.env Check #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Patch: Address Failing Check and Add Config.env Check #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a76976a
fix whitespace in directory name
Jdubrick Jan 6, 2025
69ed212
add logic for requiring config file for image builds
Jdubrick Jan 6, 2025
dc49dc6
update container image arg
Jdubrick Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/validate-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ jobs:
for dir in ${ALL_CHANGED_FILES}; do
echo "Change detected in $dir ..."
cd $dir
if [ ! -f config.env ]; then
if [ ! -f config.env ] && ([ -f Dockerfile ] || [ -f Containerfile ]); then
echo "No config.env file present in changed directory that contains image files. Throwing error ..."
exit 1
elif [ ! -f config.env ]; then
echo "No config.env file present in changed directory, skipping ..."
cd $BASE_DIR
continue
Expand Down
0 models/detr-resnet-101 /.dockerignore → models/detr-resnet-101/.dockerignore
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion models/detr-resnet-101 /Containerfile → models/detr-resnet-101/Containerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
FROM registry.access.redhat.com/ubi9/ubi-micro:9.4-9

# Can be substituted using the --build-arg defined above
ARG MODEL_URL=./detr-resnet-101
ARG MODEL_URL=./

# By default the Model Server container image uses the AI Model stored in the model/model.file file.
WORKDIR /model
Expand Down
0 models/detr-resnet-101 /README.md → models/detr-resnet-101/README.md
View file
Open in desktop
File renamed without changes.
0 models/detr-resnet-101 /config.env → models/detr-resnet-101/config.env
View file
Open in desktop
File renamed without changes.
Loading