-
Notifications
You must be signed in to change notification settings - Fork 8
[ RHDHPAI-1034] Update Models & Model Servers in Software Templates #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Lucas Yoon <[email protected]>
Signed-off-by: Lucas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small comments, once this is all approved you will need to build the images and push them to our quay. Currently the on merge push CI/CD is disabled because some images were too large for GH to handle on our tier
WORKDIR /app | ||
RUN dnf install -y git cmake make gcc-toolset-13-gcc gcc-toolset-13-gcc-c++ | ||
|
||
RUN source /opt/rh/gcc-toolset-13/enable && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be pinned to avoid grabbing a newer version if rebuilt in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pinned the install versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #56 (comment), I accidentally clicked the wrong annotation, still works to pin what you did though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If CI is failing we can revert these ones and its probably okay
Signed-off-by: Lucas <[email protected]>
Signed-off-by: Lucas <[email protected]>
What does this PR do?:
Updates the models/model servers:
llamacpp python: 0.3.8 -> 0.3.16
vllm 0.8.4 -> 0.11.0
whispercpp 1.7.6 -> 1.8.0,
Which issue(s) this PR fixes:
https://issues.redhat.com/browse/RHDHPAI-1034
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.
Tested and Verified
Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)
How to test changes / Special notes to the reviewer: