Skip to content

Conversation

JslYoon
Copy link
Contributor

@JslYoon JslYoon commented Oct 8, 2025

What does this PR do?:

Updates the models/model servers:
llamacpp python: 0.3.8 -> 0.3.16
vllm 0.8.4 -> 0.11.0
whispercpp 1.7.6 -> 1.8.0,

Which issue(s) this PR fixes:

https://issues.redhat.com/browse/RHDHPAI-1034

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.

  • Tested and Verified

  • Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)

How to test changes / Special notes to the reviewer:

Lucas Yoon and others added 2 commits October 6, 2025 14:06
@JslYoon JslYoon requested a review from a team as a code owner October 8, 2025 20:54
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small comments, once this is all approved you will need to build the images and push them to our quay. Currently the on merge push CI/CD is disabled because some images were too large for GH to handle on our tier

WORKDIR /app
RUN dnf install -y git cmake make gcc-toolset-13-gcc gcc-toolset-13-gcc-c++

RUN source /opt/rh/gcc-toolset-13/enable && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be pinned to avoid grabbing a newer version if rebuilt in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pinned the install versions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #56 (comment), I accidentally clicked the wrong annotation, still works to pin what you did though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI is failing we can revert these ones and its probably okay

@JslYoon JslYoon requested a review from Jdubrick October 9, 2025 15:41
Signed-off-by: Lucas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants