Skip to content

Conversation

rh-tap-build-team[bot]
Copy link
Contributor

@rh-tap-build-team rh-tap-build-team bot commented Sep 14, 2025

Copy link

openshift-ci bot commented Sep 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rh-tap-build-team[bot]
Once this PR has been reviewed and has the lgtm label, please assign ifireball for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Code Review by Gemini

The changes update the Git reference (SHA) for the project-controller Kustomize base and the corresponding image tag in both development and staging environments. This is a standard version update.

File: components/project-controller/development/kustomization.yaml

  • Issue/Improvement: The new Git SHA 30ce3b539b3c06795f3a0a1d52d2f6635ff6c594 is used for both the remote Kustomize base reference and the image tag. It is critical to verify that this SHA precisely corresponds to the intended version of the project-controller and the associated image. If this SHA is incorrect, it would lead to deploying an unintended version.

  • Suggested Change (if SHA is incorrect):

    --- a/components/project-controller/development/kustomization.yaml
    +++ b/components/project-controller/development/kustomization.yaml
    @@ -1,12 +1,12 @@
     apiVersion: kustomize.config.k8s.io/v1beta1
     kind: Kustomization
     resources:
     - ../base
    -- https://github.com/konflux-ci/project-controller/config/default?ref=b252edc9e91cb5e5ffb1834dd2c91bdcaa1d0569
    +- https://github.com/konflux-ci/project-controller/config/default?ref=<CORRECT_SHA_HERE>
     
     images:
     - name: konflux-project-controller
       newName: quay.io/konflux-ci/project-controller
    -- newTag: b252edc9e91cb5e5ffb1834dd2c91bdcaa1d0569
    +- newTag: <CORRECT_SHA_HERE>
     
     namespace: project-controller

File: components/project-controller/staging/kustomization.yaml

  • Issue/Improvement: Similar to the development environment, the new Git SHA 30ce3b539b3c06795f3a0a1d52d2f6635ff6c594 is used for both the remote Kustomize base reference and the image tag. It is essential to verify that this SHA accurately reflects the desired version for the staging environment. An incorrect SHA here would result in deploying an unintended version to staging.

  • Suggested Change (if SHA is incorrect):

    --- a/components/project-controller/staging/kustomization.yaml
    +++ b/components/project-controller/staging/kustomization.yaml
    @@ -1,12 +1,12 @@
     apiVersion: kustomize.config.k8s.io/v1beta1
     kind: Kustomization
     resources:
       - ../base
    -- https://github.com/konflux-ci/project-controller/config/default?ref=b252edc9e91cb5e5ffb1834dd2c91bdcaa1d0569
    +- https://github.com/konflux-ci/project-controller/config/default?ref=<CORRECT_SHA_HERE>
     
     images:
     - name: konflux-project-controller
       newName: quay.io/konflux-ci/project-controller
    -- newTag: b252edc9e91cb5e5ffb1834dd2c91bdcaa1d0569
    +- newTag: <CORRECT_SHA_HERE>
     
     namespace: project-controller

Copy link
Contributor

Code Review by Gemini

The changes correctly update the ref for the remote Kustomize base and the newTag for the konflux-project-controller image in both the development and staging kustomization files. This is a standard version update.

No bugs or issues were found in the provided diff. The changes are consistent and correctly applied.

Copy link
Contributor

Code Review by Gemini

The changes in components/project-controller/development/kustomization.yaml update the Git commit SHA for both the remote Kustomize base and the konflux-project-controller image tag. This is a consistent version bump.

There are no bugs or issues in the provided diff. The syntax is correct, and the update is applied consistently to both the resource reference and the image tag.

No changes are suggested for the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants