internal-services update

[rh-tap-build-team]

Included PRs:

• chore(deps): update konflux references konflux-ci/internal-services#310
• chore(deps): replace redhat-appstudio-tekton-catalog references konflux-ci/internal-services#309
• chore(deps): update registry.access.redhat.com/ubi9/go-toolset docker tag to v9.6-1756993846 konflux-ci/internal-services#319
• chore(actions): bump securego/gosec from 5af1117217e476b56a63eaa9ea28eeeb91fbc5ff to 3ead143f0a3b5ace623f1865ea0f560bf730cd32 konflux-ci/internal-services#325
• chore(deps): update golang.org/x/exp digest to df92998 konflux-ci/internal-services#320
• chore(deps): update registry.access.redhat.com/ubi9-minimal docker tag to v9.6-1758184547 konflux-ci/internal-services#327
• chore(deps): update google.golang.org/genproto/googleapis/rpc digest to 9702482 konflux-ci/internal-services#321
• chore(deps): update konflux references konflux-ci/internal-services#328
• chore(deps): update google.golang.org/genproto/googleapis/api digest to 9702482 konflux-ci/internal-services#249
• chore(deps): update github.com/google/pprof digest to 8b542ba konflux-ci/internal-services#329

[github-actions]

Code Review by Gemini

components/internal-services/kustomization.yaml

Improvement:

Consider adding a comment to the kustomization.yaml file to explain the reason for updating the CRD reference to this specific commit hash. This improves maintainability and makes it easier for future developers to understand the context of the change without needing to consult the commit history or external PRs.

--- a/components/internal-services/kustomization.yaml
+++ b/components/internal-services/kustomization.yaml
@@ -4,6 +4,7 @@
 - internal_service_request_service_account.yaml
 - internal_service_service_account_token.yaml
 - internal-services.yaml
+- # Update CRDs to reflect changes from konflux-ci/internal-services/pull/310
 - https://github.com/konflux-ci/internal-services/config/crd?ref=05cac0e3c04a002645983632172cb9b2d814a93d
 
 apiVersion: kustomize.config.k8s.io/v1beta1

[github-actions]

Code Review by Gemini

The change updates the Git reference for the internal-services CRD in the kustomization.yaml file.

--- a/components/internal-services/kustomization.yaml
+++ b/components/internal-services/kustomization.yaml
@@ -1,12 +1,12 @@
 resources:
 - internal_service_request_role.yaml
 - internal_service_request_role_binding.yaml
 - internal_service_request_service_account.yaml
 - internal_service_service_account_token.yaml
 - internal-services.yaml
-- https://github.com/konflux-ci/internal-services/config/crd?ref=957f69fadd27b34c749b9ecc79933f311d8cf91c
+- https://github.com/konflux-ci/internal-services/config/crd?ref=ac050a9626da682a0b6a1f5eaafaa7609f99d8c2

This is a straightforward update of a dependency's CRD version. Assuming the new commit hash ac050a9626da682a0b6a1f5eaafaa7609f99d8c2 is the intended and correct reference for the updated CRD, there are no bugs or issues in this change.

Improvements:
No specific improvements are suggested for this change, as updating a Git reference to a specific commit hash is a valid and precise way to manage dependency versions in Kustomize.

[github-actions]

Code Review by Gemini

The provided diff updates the ref for the internal-services CRD in the kustomization.yaml file. This is a valid change to pull in newer CRD definitions.

There are no bugs or issues in the provided code changes. The update of the Git reference is a standard practice for managing dependencies in Kustomize.

--- a/components/internal-services/kustomization.yaml
+++ b/components/internal-services/kustomization.yaml
@@ -6,4 +6,4 @@
 - internal_service_request_service_account.yaml
 - internal_service_service_account_token.yaml
 - internal-services.yaml
-- https://github.com/konflux-ci/internal-services/config/crd?ref=957f69fadd27b34c749b9ecc79933f311d8cf91c
+- https://github.com/konflux-ci/internal-services/config/crd?ref=8f81d0253425ce382e70a11ac8f526bf967f8bc6

[github-actions]

Code Review by Gemini

The change updates the Git reference for fetching Custom Resource Definitions (CRDs) from the konflux-ci/internal-services repository. This is a standard way to manage external Kustomize resources.

Potential Issues & Improvements:

• CRD Version Verification: The new commit hash 42525cb5b5c11259934885dc967f84e030d3ec2c is a critical dependency. It is essential to verify that this specific commit hash points to the correct and intended version of the CRDs, ensuring it includes all necessary changes from the listed PRs (chore(deps): update konflux references konflux-ci/internal-services#310, chore(deps): replace redhat-appstudio-tekton-catalog references konflux-ci/internal-services#309, chore(deps): update registry.access.redhat.com/ubi9/go-toolset docker tag to v9.6-1756993846 konflux-ci/internal-services#319) and is compatible with the internal-services application version being deployed. An incorrect reference could lead to deployment failures or runtime issues due to schema mismatches.

  No specific line change is suggested here, as the current line is syntactically correct. This is a verification step for the new reference.

[openshift-ci]

@rh-tap-build-team[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/appstudio-upgrade-tests	0aee47b	link	false	/test appstudio-upgrade-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rh-tap-build-team[bot]

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment