Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(KFLUXVNGD-197): Add HypershiftAWSQuotaAlmostFull alerting rule" #471

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

amisstea
Copy link
Collaborator

Reverts #469

I discovered the quota isn't being enforced as I expected (it's actually namespaced, not cluster-scoped). Reverting for now.

@amisstea
Copy link
Collaborator Author

On second thought, this can still be enforced with a ClusterResourceQuota so I'll make those changes instead.

@amisstea amisstea closed this Feb 20, 2025
@amisstea amisstea deleted the revert-469-KFLUXVNGD-187 branch February 20, 2025 19:57
@amisstea amisstea restored the revert-469-KFLUXVNGD-187 branch February 24, 2025 13:36
@amisstea
Copy link
Collaborator Author

According to the OCP docs, ClusterResourceQuotas must define a selector that should match active namespaces to the order of dozens at most. The namespaces will contend on this quota during object creation so it can create a performance bottleneck. We must plan to scale into the hundreds of active namespaces at a minimum so this might cause problems for us.

With no great option for enforcing a global quota I'm back to the point where reverting this alerting rule is probably the best option. @mftb @mike-kingsbury please review.

@amisstea amisstea reopened this Feb 24, 2025
@mike-kingsbury
Copy link
Collaborator

/lgtm
/approve

@amisstea amisstea merged commit 6e2765d into main Mar 4, 2025
2 checks passed
@amisstea amisstea deleted the revert-469-KFLUXVNGD-187 branch March 4, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants