Support environment variables in Jenkins #140
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnevrlka
force-pushed
the
jenkins-env-vars
branch
3 times, most recently
from
78e484f to
da05a5a
Compare
|
The affected files are re-generated in #137 and not included in this pull request since they are not relevant to Jenkins. Once #137 is merged and this PR is rebased, the check should start to pass |
tnevrlka
force-pushed
the
jenkins-env-vars
branch
2 times, most recently
from
68e07a4 to
73a59e5
Compare
tnevrlka
force-pushed
the
jenkins-env-vars
branch
from
73a59e5 to
8a26576
Compare
All variables are being created as credentials in Jenkins. Credentials get masked in Jenkins logs which is unwanted for non-secret variables that should be exposed to users via EYECATCHER. Add a script for creating a Jenkins global variable and use it in the existing hack script for setup Signed-off-by: Tomáš Nevrlka <[email protected]>
Currently, every environment variable is treated as a credential and thus masked in the logs. Some of the environment variables should be visible in the logs. Change the templates so they use global variables in Jenkins for them. Signed-off-by: Tomáš Nevrlka <[email protected]>
tnevrlka
force-pushed
the
jenkins-env-vars
branch
from
8a26576 to
7298a17
Compare
lcarva
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #137 which should be merged first (using a cherry-picked commit from it)
Currently, every environment variable is treated as a credential and
thus masked in the logs.
Some of the environment variables should be visible in the logs.
Update the
hack/jenkins-set-secrets(and rename it tohack/jenkins-set-variables) to set both unmasked variables and secrets.Change the templates so they use global variables in Jenkins when secrets are not needed