Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile details #114

Merged
merged 4 commits into from
Jun 8, 2023
Merged

Profile details #114

merged 4 commits into from
Jun 8, 2023

Conversation

TalReinfeld
Copy link
Contributor

@TalReinfeld TalReinfeld commented May 16, 2023 •
edited
Loading

Adding a html file (profile_details) that extends profile.html,
the file show all the profile details.

Adding css file for the above.

Adding a test to check the file content.

Changing the urls for the new pages. - http://127.0.0.1:8000/profile/settings/

This PR is depends on PR #127

Solve issue #107

image

image

image

@TalReinfeld TalReinfeld self-assigned this May 16, 2023
idoyek
idoyek approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@idoyek idoyek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TalReinfeld TalReinfeld marked this pull request as draft May 21, 2023 06:01
@TalReinfeld TalReinfeld marked this pull request as ready for review May 21, 2023 07:01
guybeckenstein
guybeckenstein approved these changes May 21, 2023
View reviewed changes
Copy link
Contributor

@guybeckenstein guybeckenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

idosinger98
idosinger98 approved these changes May 21, 2023 •
edited
Loading
View reviewed changes
Yarboa
Yarboa requested changes May 21, 2023
View reviewed changes
Copy link
Contributor

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review comments
You do not assert the content of the rersponses

account/tests/urls_tests/test_professional.py Outdated Show resolved Hide resolved
account/templates/account/profile_details.html Outdated Show resolved Hide resolved
account/templates/account/profile_details.html Outdated Show resolved Hide resolved
account/views/client_views.py Outdated Show resolved Hide resolved
idosinger98
idosinger98 requested changes May 24, 2023
View reviewed changes
Copy link
Contributor

@idosinger98 idosinger98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use base.html

@TalReinfeld TalReinfeld marked this pull request as draft May 24, 2023 15:26
@TalReinfeld TalReinfeld marked this pull request as ready for review May 28, 2023 16:58
@TalReinfeld
Copy link
Contributor Author

Please use base.html

@idosinger98 Done

idosinger98
idosinger98 reviewed May 28, 2023
View reviewed changes
Copy link
Contributor

@idosinger98 idosinger98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please convert to draft

idosinger98
idosinger98 reviewed May 28, 2023
View reviewed changes
Copy link
Contributor

@idosinger98 idosinger98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please convert to draft

@TalReinfeld TalReinfeld marked this pull request as draft May 29, 2023 16:28
@TalReinfeld TalReinfeld marked this pull request as ready for review June 5, 2023 17:21
@guybeckenstein guybeckenstein added the CoreReview-Ready Ready for mentor review label Jun 6, 2023
@Yarboa
Copy link
Contributor

Yarboa commented Jun 7, 2023

I think you need to rebase

@TalReinfeld
Adding profile details
31a7557 
Signed-off-by: TalReinfeld <[email protected]>
@TalReinfeld
Fixing bugs
a4ac1d1 
Signed-off-by: TalReinfeld <[email protected]>
Yarboa
Yarboa approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yarboa Yarboa merged commit 8eba3b5 into redhat-beyond:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idoyek idoyek idoyek approved these changes

@guybeckenstein guybeckenstein guybeckenstein approved these changes

@Yarboa Yarboa Yarboa approved these changes

@OfirBachar OfirBachar Awaiting requested review from OfirBachar OfirBachar is a code owner

@patrisiakaplun patrisiakaplun Awaiting requested review from patrisiakaplun patrisiakaplun is a code owner

@idosinger98 idosinger98 Awaiting requested review from idosinger98 idosinger98 is a code owner

Assignees

@TalReinfeld TalReinfeld

Labels
CoreReview-Ready Ready for mentor review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TalReinfeld @Yarboa @guybeckenstein @idoyek @idosinger98