Updating search feature #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoyek
requested review from
idosinger98,
OfirBachar,
TalReinfeld,
patrisiakaplun and
guybeckenstein
as code owners
Signed-off-by: Ido Yekutiel <[email protected]>
|
it needs to be connected to the search bar from |
@guybeckenstein I will do it in a different PR, opened an issue for it #141 |
Signed-off-by: Ido Yekutiel <[email protected]>
Yarboa
reviewed
Jun 8, 2023
SearchHistory/test_search_page.py
Outdated
| professional = make_professional() | ||
| typeOfjobs_by_pro = TypeOfJob.get_typeofjobs_by_professional(professional_id=professional.professional_id) | ||
| client.force_login(professional.profile_id.user_id) | ||
| url = reverse('show professional', args=[PROFESSIONAL_ID]) |
There was a problem hiding this comment.
Please avoid hardcode
You should test it through the data exist in tests and operations
You should get the url different way
There was a problem hiding this comment.
@Yarboa Done and merged with main
SearchHistory/test_search_page.py
Outdated
| response = client.post(url, data) | ||
|
|
||
| assert response.status_code == 200 | ||
| assert 'account/business_page.html' in response.templates[0].name |
There was a problem hiding this comment.
Is there ant data to assert?
There was a problem hiding this comment.
@Yarboa Done and merged with main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@OfirBachar and I updated search.html and css to fit to the application style.
When pressing "Open" button on a professional box, now it not only add him to the client's search history, but also redirect to the chosen professional's page.
We've also added a test that checks the redirection to the relevant professional's page.
Here is a picture with the new style:
Resolves #139