Skip to content

Conversation

anandf
Copy link
Member

@anandf anandf commented Aug 12, 2025

What type of PR is this?
/kind enhancement

What does this PR do / why we need it:
It was not possible to change the resource requirements and limits for some of the pods like gitops-plugin, cluster and gitops-backend.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/enhancement New feature or request label Aug 12, 2025
@anandf anandf force-pushed the add_resource_constraints branch from 83f5599 to 1157a47 Compare August 12, 2025 08:28
@openshift-ci openshift-ci bot requested review from jannfis and svghadi August 12, 2025 08:28
Copy link

openshift-ci bot commented Aug 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chetan-rns for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@svghadi
Copy link
Member

svghadi commented Aug 12, 2025

Looks good. Do we need additional logic to handle updates to resources?

@anandf anandf force-pushed the add_resource_constraints branch from 1157a47 to 6c230e2 Compare September 16, 2025 06:58
Signed-off-by: Anand Francis Joseph <[email protected]>
Copy link

openshift-ci bot commented Sep 16, 2025

@anandf: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-kuttl-parallel 87327e1 link true /test v4.14-kuttl-parallel
ci/prow/v4.17-kuttl-parallel 87327e1 link true /test v4.17-kuttl-parallel
ci/prow/v4.19-kuttl-parallel 87327e1 link true /test v4.19-kuttl-parallel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants