-
Notifications
You must be signed in to change notification settings - Fork 343
[GITOPS-7844]: GitOpsService controller creates default ArgoCD with v1alpha1 api version #976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GITOPS-7844]: GitOpsService controller creates default ArgoCD with v1alpha1 api version #976
Conversation
…1alpha1 api version Signed-off-by: akhil nittala <[email protected]>
Skipping CI for Draft Pull Request. |
…1alpha1 api version Signed-off-by: akhil nittala <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: svghadi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/retest |
/retest-required |
/lgtm |
e8ca4e7
into
redhat-developer:master
/cherry-pick v1.18 |
/cherry-pick v1.17 |
@svghadi: new pull request created: #985 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@svghadi: new pull request created: #986 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What does this PR do / why we need it:
Creates default argocd with v1beta1
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
http://issues.redhat.com/browse/GITOPS-7844
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer:
create default argocd instance and also test by deleting it and verify the api version of default argocd