Skip to content

Conversation

akhilnittala
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug

/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:
Creates default argocd with v1beta1
Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:
http://issues.redhat.com/browse/GITOPS-7844
Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:
create default argocd instance and also test by deleting it and verify the api version of default argocd

Copy link

openshift-ci bot commented Sep 29, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the kind/bug Something isn't working label Sep 29, 2025
@akhilnittala akhilnittala marked this pull request as ready for review October 1, 2025 09:09
@openshift-ci openshift-ci bot requested review from jannfis and svghadi October 1, 2025 09:10
@akhilnittala akhilnittala requested review from anandf and anandrkskd and removed request for jannfis October 1, 2025 09:10
@akhilnittala akhilnittala requested a review from svghadi October 6, 2025 06:35
@svghadi
Copy link
Member

svghadi commented Oct 6, 2025

/lgtm
/approve

Copy link

openshift-ci bot commented Oct 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 6, 2025
@akhilnittala
Copy link
Contributor Author

/retest-required

@openshift-ci openshift-ci bot removed the lgtm label Oct 6, 2025
@varshab1210
Copy link
Member

/retest

@akhilnittala
Copy link
Contributor Author

/retest-required

@svghadi
Copy link
Member

svghadi commented Oct 8, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 8, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit e8ca4e7 into redhat-developer:master Oct 8, 2025
16 checks passed
@svghadi
Copy link
Member

svghadi commented Oct 8, 2025

/cherry-pick v1.18

@svghadi
Copy link
Member

svghadi commented Oct 8, 2025

/cherry-pick v1.17

@openshift-cherrypick-robot

@svghadi: new pull request created: #985

In response to this:

/cherry-pick v1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@svghadi: new pull request created: #986

In response to this:

/cherry-pick v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved kind/bug Something isn't working lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants