-
Notifications
You must be signed in to change notification settings - Fork 81
feat(Extensions): Add translation support for Extensions #1410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Extensions): Add translation support for Extensions #1410
Conversation
b69b3c2 to
62d5dbb
Compare
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Unexpected ChangesetsThe following changeset(s) reference packages that have not been changed in this PR:
Note that only changes that affect the published package require changesets, for example changes to tests and storybook stories do not require changesets. Changed Packages
|
62d5dbb to
88cb2c1
Compare
|
Tested Locally, |
christoph-jerolimov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, really nice work, I have just two suggestions:
-
You translated a lot of Skeletons usages which is imo not needed. Wdyt?
-
I added an idea about removing the Trans component and using MarkdownContent instead.
-
And finally, you also translate the Catalog entites. It's nice, but I don't know if we really want that for now.... Really unsure... 🤔
Can you maybe test if you can alternatively, add a 2nd property to
examples/collections/featured.yamland if we can use that as translation? Maybe its worth to put this into a 2nd PR.# yaml-language-server: $schema=../../json-schema/collections.json apiVersion: extensions.backstage.io/v1alpha1 kind: PluginCollection metadata: namespace: marketplace-plugin-demo name: featured title: Featured Plugins titleKey: collection.featured.title description: A set of great plugins! :) descriptionKey: collection.featured.description spec: type: curated plugins: - quay - 3scale - tekton - topology
fyi: These collections aren't used yet in our product.
workspaces/marketplace/plugins/marketplace/src/components/CollectionHorizontalScrollRow.tsx
Outdated
Show resolved
Hide resolved
workspaces/marketplace/plugins/marketplace/src/translations/ref.ts
Outdated
Show resolved
Hide resolved
workspaces/marketplace/plugins/marketplace/src/components/MarketplacePackageContent.tsx
Outdated
Show resolved
Hide resolved
workspaces/marketplace/plugins/marketplace/src/components/MarketplacePackageContent.tsx
Outdated
Show resolved
Hide resolved
workspaces/marketplace/plugins/marketplace/src/components/MarketplacePluginContent.tsx
Outdated
Show resolved
Hide resolved
workspaces/marketplace/plugins/marketplace/src/components/MarketplacePluginContent.tsx
Outdated
Show resolved
Hide resolved
workspaces/marketplace/plugins/marketplace/src/components/PluginCard.tsx
Outdated
Show resolved
Hide resolved
workspaces/marketplace/plugins/marketplace/src/components/MarketplaceCatalogContent.tsx
Outdated
Show resolved
Hide resolved
|
New changes are detected. LGTM label has been removed. |
5cf48c2 to
530022d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lokanandaprabhu, this got conflicts after we (I) merged
Another bigger PR from @ciiay is WIP that changes again a lot of strings
Maybe its best to wait until this is also merged and rebase your changes after that.
Sorry that we worked on 3 important changes at the same time on the same code base... 🤷♂️
…, and Spanish translations
530022d to
085fe08
Compare
085fe08 to
597753a
Compare
05f2f1e to
ad0f540
Compare
christoph-jerolimov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @lokanandaprabhu 👍
Thanks for keeping this updated after the other PRs breaks this.
This lgtm, I would just extract the utils function that was there 3 times. Or remove it. (Final decision in slack... ;))
workspaces/marketplace/plugins/marketplace/src/components/CollectionHorizontalScrollRow.tsx
Outdated
Show resolved
Hide resolved
workspaces/marketplace/plugins/marketplace/src/components/MarketplaceCollectionGrid.tsx
Outdated
Show resolved
Hide resolved
workspaces/marketplace/plugins/marketplace/src/pages/MarketplaceCollectionPage.tsx
Outdated
Show resolved
Hide resolved
3bda6e2 to
b115856
Compare
b115856 to
f957bf4
Compare
Signed-off-by: its-mitesh-kumar <[email protected]>
lokanandaprabhu:feature/RHIDP-8742Pr 1410
Signed-off-by: its-mitesh-kumar <[email protected]>
re-updating api report
|


Translation support to Extensions
Fixes
https://issues.redhat.com/browse/RHIDP-8742
Added internationalization (i18n) support to Extensions. The plugin now supports multiple languages with proper fallbacks and maintains all existing functionality.
Languages added:
Screenshots
✔️ Checklist