Skip to content

feat(global-header): adding company logo in global header #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

feat(global-header): adding company logo in global header #2893

wants to merge 4 commits into from

Conversation

its-mitesh-kumar
Copy link
Member

@its-mitesh-kumar its-mitesh-kumar commented May 20, 2025 •
edited
Loading

Description

  • Updating default configuration for Adding Company Logo in Global Header
  • Updating Global Header version to 1.10.1

Which issue(s) does this PR fix

UI after changes

1. Dark theme View with Default Configuration

Screenshot 2025-06-19 at 7 27 44 PM

*2. Light theme View with Default Configuration

Screenshot 2025-06-19 at 7 27 52 PM

Testing

For testing default view in local, we need to copy below default configurations from dynamic-plugins.default.yaml in app-config.yaml.

      app:
        sidebar:
          search: false
          settings: false
          logo: false

And

      dynamicPlugins:
        frontend:
          default.main-menu-items:
            menuItems:
              default.create:
                title: ''
          red-hat-developer-hub.backstage-plugin-global-header:
            mountPoints:
              - mountPoint: application/header
                importName: GlobalHeader
                config:
                  position: above-sidebar # above-main-content | above-sidebar
              - mountPoint: global.header/component
                importName: CompanyLogo
                config:
                  priority: 200
                  props:
                    to: '/'
              - mountPoint: global.header/component
                importName: SearchComponent
                config:
                  priority: 100
              - mountPoint: global.header/component
                importName: Spacer
                config:
                  priority: 99
                  props:
                    growFactor: 0
              - mountPoint: global.header/component
                importName: HeaderIconButton
                config:
                  priority: 90
                  props:
                    title: Self-service
                    icon: add
                    to: create
              - mountPoint: global.header/component
                importName: SupportButton
                config:
                  priority: 80
              - mountPoint: global.header/component
                importName: NotificationButton
                config:
                  priority: 70
              - mountPoint: global.header/component
                importName: Divider
                config:
                  priority: 50
              - mountPoint: global.header/component
                importName: ProfileDropdown
                config:
                  priority: 10
              - mountPoint: global.header/profile
                importName: MenuItemLink
                config:
                  priority: 100
                  props:
                    title: Settings
                    link: /settings
                    icon: manageAccounts
              - mountPoint: global.header/profile
                importName: LogoutButton
                config:
                  priority: 10

@openshift-ci openshift-ci bot requested review from dzemanov and nickboldt May 20, 2025 18:43
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign christoph-jerolimov for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@its-mitesh-kumar its-mitesh-kumar marked this pull request as draft May 20, 2025 18:43
@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@github-actions github-actions bot added the Stale label May 28, 2025
@its-mitesh-kumar its-mitesh-kumar marked this pull request as ready for review June 3, 2025 03:40
@openshift-ci openshift-ci bot requested a review from coreydaley June 3, 2025 03:41
@invincibleJai
Copy link
Member

/retest

invincibleJai
invincibleJai reviewed Jun 4, 2025
View reviewed changes
dynamic-plugins/wrappers/red-hat-developer-hub-backstage-plugin-global-header/package.json Outdated
{
"name": "red-hat-developer-hub-backstage-plugin-global-header",
"version": "1.6.0",
"version": "1.7.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 1.8.0?

https://www.npmjs.com/package/@red-hat-developer-hub/backstage-plugin-global-header/v/1.8.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use the latest which is 1.9.0 now
https://www.npmjs.com/package/@red-hat-developer-hub/backstage-plugin-global-header

@github-actions github-actions bot removed the Stale label Jun 6, 2025
@its-mitesh-kumar
Copy link
Member Author

/retest-required

@ciiay
Copy link
Member

ciiay commented Jun 6, 2025

/test e2e-tests

1 similar comment
@ciiay
Copy link
Member

ciiay commented Jun 6, 2025

/test e2e-tests

ciiay
ciiay reviewed Jun 6, 2025
View reviewed changes
dynamic-plugins/wrappers/red-hat-developer-hub-backstage-plugin-global-header/package.json Outdated
"dependencies": {
"@mui/material": "5.17.1",
"@red-hat-developer-hub/backstage-plugin-global-header": "1.6.0"
"@red-hat-developer-hub/backstage-plugin-global-header": "1.7.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here also needs to be same as the wrapper version.

@its-mitesh-kumar
Copy link
Member Author

/retest-required

@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@github-actions github-actions bot added the Stale label Jun 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@its-mitesh-kumar
Copy link
Member Author

Dark theme View with Default Configuration
Screenshot 2025-06-19 at 7 27 44 PM

Light theme View with Default Configuration
Screenshot 2025-06-19 at 7 27 52 PM

@its-mitesh-kumar
updating to 1.10.1
1eea334 
Signed-off-by: its-mitesh-kumar <[email protected]>
@its-mitesh-kumar
Copy link
Member Author

/cc @logonoff @ciiay

@openshift-ci openshift-ci bot requested review from ciiay and logonoff June 19, 2025 14:07
@logonoff
Copy link
Member

/cc @logonoff @ciiay

/hold

we should wait for redhat-developer/rhdh-plugins#981 to merge first so we can include it in this PR

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions github-actions bot removed the Stale label Jun 21, 2025
@its-mitesh-kumar
Copy link
Member Author

@logonoff, I can see your PR has been merged, should we proceed now for updating the global header version?

/cc @logonoff @ciiay

/hold

we should wait for redhat-developer/rhdh-plugins#981 to merge first so we can include it in this PR

@logonoff
Copy link
Member

@logonoff, I can see your PR has been merged, should we proceed now for updating the global header version?

/cc @logonoff @ciiay

/hold
we should wait for redhat-developer/rhdh-plugins#981 to merge first so we can include it in this PR

Please do! Also make sure to update catalog-entities/marketplace/packages/red-hat-developer-hub-backstage-plugin-global-header.yaml as well

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 24, 2025

@its-mitesh-kumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests c6d987a link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@its-mitesh-kumar
Copy link
Member Author

Closing this PR as the changes of this PR has been included in #3023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invincibleJai invincibleJai invincibleJai left review comments

@dzemanov dzemanov Awaiting requested review from dzemanov

@nickboldt nickboldt Awaiting requested review from nickboldt

@coreydaley coreydaley Awaiting requested review from coreydaley

@ciiay ciiay Awaiting requested review from ciiay

@logonoff logonoff Awaiting requested review from logonoff

Assignees
No one assigned
Labels
do-not-merge/hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@its-mitesh-kumar @invincibleJai @ciiay @logonoff