-
Notifications
You must be signed in to change notification settings - Fork 206
fix(dynamic-plugins-info): remove scalprum dep #3281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The image is available at: |
|
The image is available at: |
This change swaps out the direct usage of useScalprum to the useMountPoints hook provided by the dynamic plugins frontend API. This change also ensures the useMountPoints hook is exported from the API package. Signed-off-by: Stan Lewis <[email protected]>
|
The image is available at: |
|
The image is available at: |
|
/retest |
|
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
|
The image is available at: |
|
/retest |
|
@gashcrumb there is also a PR to remove |
dzemanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dzemanov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dzemanov oh, right on, maybe this change isn't really needed then. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
looking at that other issue, I think I'll hold off on this change and can look at doing this as part of RHIDP-6887 against wherever this implementation winds up. |

Description
This change swaps out the direct usage of useScalprum to the useMountPoints hook provided by the dynamic plugins frontend API. This change also ensures the useMountPoints hook is exported from the API package.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer