Skip to content

Conversation

@gashcrumb
Copy link
Member

Description

This change swaps out the direct usage of useScalprum to the useMountPoints hook provided by the dynamic plugins frontend API. This change also ensures the useMountPoints hook is exported from the API package.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

This change swaps out the direct usage of useScalprum to the
useMountPoints hook provided by the dynamic plugins frontend API.  This
change also ensures the useMountPoints hook is exported from the API
package.

Signed-off-by: Stan Lewis <[email protected]>
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@gashcrumb
Copy link
Member Author

/retest

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@github-actions github-actions bot added the Stale label Sep 4, 2025
@gashcrumb gashcrumb removed the Stale label Sep 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

@gashcrumb
Copy link
Member Author

/retest

@dzemanov
Copy link
Member

dzemanov commented Sep 9, 2025

@gashcrumb there is also a PR to remove dynamic-plugins-info plugin #3366

Copy link
Member

@dzemanov dzemanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine
Screenshot 2025-09-09 at 11 00 26

@openshift-ci
Copy link

openshift-ci bot commented Sep 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dzemanov
Once this PR has been reviewed and has the lgtm label, please assign invinciblejai for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gashcrumb
Copy link
Member Author

@dzemanov oh, right on, maybe this change isn't really needed then.

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gashcrumb
Copy link
Member Author

looking at that other issue, I think I'll hold off on this change and can look at doing this as part of RHIDP-6887 against wherever this implementation winds up.

@gashcrumb gashcrumb closed this Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants