RI-7687 Adjust RDI job config page #5152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemHoruzhenko
requested review from
DimoHG,
KrumTy,
dantovska,
pawelangelow,
pd-redis and
valkirilov
as code owners
Contributor
Code Coverage - Frontend unit tests
Test suite run success5255 tests passing in 687 suites. Report generated by 🧪jest coverage report action from df12ae0 |
valkirilov
changed the title
valkirilov
previously approved these changes
Nov 7, 2025
| import { FlexItem } from 'uiSrc/components/base/layout/flex' | ||
|
|
||
| export const StyledRdiJobConfigContainer = styled(FlexItem)` | ||
| padding: 2.4rem; |
Member
There was a problem hiding this comment.
nit: You can also use the theme, they have an equivalent variable for this spacing.(example)
Suggested change
| padding: 2.4rem; | |
| padding: ${({ theme }: { theme: Theme }) => theme.core.space.space300}; |
ArtemHoruzhenko
dismissed stale reviews from valkirilov and KrumTy
via
3cd5b91
valkirilov
approved these changes
Nov 7, 2025
ArtemHoruzhenko
deleted the
fe/feature/RI-7687-adjust-RDI-job-config-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
reworked:
known issues which will be addressed in a separate tasks
Testing
Screen.Recording.2025-11-06.at.17.11.11.mov