feat(proto): support scanning uuid.UUID in Scan() #3425
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @LinYuan201712 |
justinhwang
reviewed
Jul 17, 2025
| case *[]byte: | ||
| *v = b | ||
| return nil | ||
| case *uuid.UUID: |
There was a problem hiding this comment.
Instead of adding support for a single uuid package, you could have individual uuid packages implement encoding.BinaryUnmarshaler to hit the case below. Not everyone who uses this package would use github.com/google/uuid as their uuid package
There was a problem hiding this comment.
Given github.com/google/uuid already implements it, you're probably looking for #3144 instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds support for scanning Redis string/bytes values into
uuid.UUIDvia theproto.Scan()function.Why
Currently, scanning into
*uuid.UUIDfails even if the Redis string is a valid UUID. This PR enhancesproto.Scan()to handle*uuid.UUIDby parsing string/[]byte viauuid.Parse.How
proto.Scanto detect*uuid.UUIDutil.BytesToStringto convert input to stringuuid.Parseto validate and assignTestScanUUIDFromRedisRelated Issue
Fixes #3139 (or your own issue link)