handle default issue with multiple inheritance

[sethbuff]

This is something we can handle in our implementation but, we wanted to put this up in case it would be helpful to others.

Prior to the pydantic 2.0 change, we were able to define abstract classes as RedisModel's and then, in implementation we could define whether we wanted it to be a HashModel or a JsonModel. After the change, any defaults we had were coming through as ExpressionProxy objects for the models with the mixins.

This fix handles multiple bases on a model to prevent this from happening.

[slorello89]

These tests pass on the current state of main, I see what you are getting at though, you are talking about multiple inheritance - so if you try to run this test on main:

@py_test_mark_asyncio
async def test_multiple_inheritance_class_expression_proxy():
    class Model(HashModel):
        first_name: str
        last_name: str
        age: int = Field(default=18)
        bio: Optional[str] = Field(default=None)

    class Sibling():
        is_sibling: bool = Field(default=True)

    class Child(Model, Sibling):
        is_child: bool = True

    await Migrator().run()
    m = Child(first_name="Steve", last_name="Lorello")
    assert m.age == 18
    await m.save()

    assert m.age == 18
    assert m.is_sibling
    assert m.is_child

    rematerialized = await Child.find(Child.pk == m.pk).first()

    assert rematerialized.age == 18
    assert rematerialized.age != 19
    assert rematerialized.bio is None
    assert rematerialized.is_sibling
    assert rematerialized.is_child

it will fail

[sethbuff]

Yes, that is exactly it. I updated the test to reflect that. I wasn't totally understanding what the issue was on our side but now that I do, we can definitely fix it in our implementation. Either way, wanted to leave this up in case it is helpful.

[slorello89]

Would you mind deleting this extra print while you are in here?

[slorello89]

I tried to push a commit removing it to your branch but my push was rejected.

[sethbuff]

Done!

[slorello89]

LGTM 👍