Skip to content

redis: increase pubsub channel buffer to prevent message drops #4310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twmb merged 1 commit into from
May 5, 2026
Merged

redis: increase pubsub channel buffer to prevent message drops #4310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/impl/redis/input_pubsub.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ func (r *redisPubSubReader) Read(ctx context.Context) (*service.Message, service
}

select {
case rMsg, open := <-pubsub.Channel():
case rMsg, open := <-pubsub.Channel(redis.WithChannelSize(2000)):
Copy link
Copy Markdown

@claude claude Bot Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The literal 2000 is a magic number. Per the godev "Magic Numbers" rule, "Name all numeric constants. Every literal number in logic must have a clear meaning through a named constant or variable." Consider extracting this to a package-level constant (e.g. const pubsubChannelBufferSize = 2000) so the rationale (buffer for concurrent writes) is tied to a named symbol.

if !open {
_ = r.disconnect()
return nil, nil, service.ErrEndOfInput
Expand Down
Loading