You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Review
One issue: the existing unit test for TYPE_DATETIME in schema_test.go was not updated to match the new RFC3339Nano string output, so task test:unit will fail.
schema_test.go:132-137 — the "time.Time passthrough for datetime" case still expects time.Date(...), but mapMessageColumn now returns "2024-12-10T15:30:45Z". Test name and expected value need updating; consider adding coverage for sub-second precision and non-UTC zones.
Review
Focused change converting MySQL CDC time.Time datetime/timestamp values to RFC3339Nano strings for downstream parquet compatibility, with the existing string-passthrough nil behavior preserved for zero/invalid timestamps. Tests cover sub-second precision and non-UTC zones.
josephwoodward
changed the title
mysql_cdc: format timestamp columns as RFC3339Nano strings for parquet compatiblity
parquet_encode: format timestamp columns as RFC3339Nano strings for compatiblity
May 7, 2026
Review
Clean refactor of encodingCoercionVisitor.visitLeaf that adds a time.Time case alongside the existing string case for TIMESTAMP encoding. The ts and unit-switch are correctly hoisted so both input types share the same conversion path, and the error message is updated to reflect the new accepted type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.