Skip to content

tx: update max_transactions description #28233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bharathv merged 1 commit into from
Oct 31, 2025
+15 −6
Merged

tx: update max_transactions description #28233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions src/v/config/configuration.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,17 +972,26 @@ configuration::configuration()
*this,
"transactional_id_expiration_ms",
"Expiration time of producer IDs. Measured starting from the time of the "
"last write until now for a given ID.",
"last write until now for a given ID. Producer IDs are automatically "
"removed from memory when they expire, which helps manage memory usage. "
"However, this natural cleanup may not be sufficient for workloads with "
"high producer churn rates. For applications with long-running "
"transactions, ensure this value accommodates your typical transaction "
"lifetime to avoid premature producer ID expiration.",
{.needs_restart = needs_restart::no, .visibility = visibility::user},
10080min)
, max_concurrent_producer_ids(
*this,
"max_concurrent_producer_ids",
"Maximum number of the active producers sessions. When the threshold is "
"passed, Redpanda terminates old sessions. When an idle producer "
"corresponding to the terminated session wakes up and produces, its "
"message batches are rejected, and an out of order sequence error is "
"emitted. Consumers don't affect this setting.",
"Maximum number of active producer sessions per shard. Each shard "
"tracks producer IDs using an LRU (Least Recently Used) eviction "
"policy. When the configured limit is exceeded, the least recently "
"used producer IDs are evicted from the cache. IMPORTANT: The default "
"value is unlimited, which can lead to unbounded memory growth and "
"out-of-memory (OOM) crashes in production environments with heavy "
"producer usage, especially when using transactions or idempotent "
"producers. It is strongly recommended to set a reasonable limit in "
"production deployments.",
Comment on lines +986 to +994
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description states 'When the configured limit is exceeded, the least recently used producer IDs are evicted from the cache,' but this behavior only applies when a limit is actually set. With the default unlimited value, no eviction occurs. Consider clarifying that eviction only happens when a finite limit is configured, e.g., 'When a finite limit is configured and exceeded, the least recently used producer IDs are evicted from the cache.'

Copilot uses AI. Check for mistakes.
{.needs_restart = needs_restart::no, .visibility = visibility::tunable},
std::numeric_limits<uint64_t>::max(),
{.min = 1})
Expand Down
Loading