-
Notifications
You must be signed in to change notification settings - Fork 713
claude: add update-seastar-sha skill command #29475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
claude: add update-seastar-sha skill command #29475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a Claude Code skill command that automates the process of updating the Seastar submodule dependency to the latest commit from the v26.1.x branch. The command simplifies what is currently a manual multi-step process into a single /update-seastar-sha invocation.
Changes:
- Adds a new Claude Code skill command file with detailed instructions for automating Seastar SHA updates
- Includes steps for fetching the latest commit, updating build files, verifying the build, and creating a PR
- Provides error handling guidance and example output
StephanDollberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surely this can be replaced with a 10 line bash script?
Maybe 15 lines 😉, but skills are nice as you can chain them together, you get the oversight of the agent and small errors go unpunished. |
StephanDollberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean it feels a bit backwards that you now have to pay money to run the most basic commands on your own machine.
| ```bash | ||
| gh api repos/redpanda-data/seastar/commits/v26.1.x --jq '.sha' | ||
| ``` | ||
| Store this as `NEW_SHA`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I first read this I thought things like NEW_SHA were files, and that this was too prescriptive. That is, Claude should perform better with declarative instructions.
But now I'm curious: is this like using a virtual storage location of sorts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure (since claude also wrote this file), but I did test it and it worked. The way I did it was to work though a PR workflow without any skill, then when it worked, got claude to go back and record the steps it uses for next time as a skill.
I know you can actually do direct substitution in these files, like this though this isn't that.
I did find some references that specifically "store this as" will put the value into long term memory, depending on the context (e.g., into MCP's external memory).
oh but it is only a few dozen orders of magnitude difference in cost between this and the money you were already paying for in form of energy for a non-idle CPU and bash script lol |
|
Drafting this while I consider a script instead. |
Add a Claude Code skill command to automate updating the Seastar submodule SHA to the latest commit from the v26.1.x branch. This provides a simple
/update-seastar-shacommand that handles fetching, updating, building, and committing the change.Backports Required
Release Notes