rpk: bump golangci-lint to v2 and fix issues #29513
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bump increased the accuracy and the report showed up to 100 issues. One of the major changes that were not fixed by the `--fix` flag were: - Package naming: common -> better names - net, os, utils -> netutil, osutil, rpkutil to avoid collision with standard naming packages - Context handling in the container package. We were using a context.Background with a timeout instead of the command context. There are further improvements to be made as moving away from some of the code in rpkutil and eliminating the containerutil package but these will be handled in separate commits to not hinder the review of this one. In addition we are also bumping the golangci-lint version in our Github Actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bump increased the accuracy and the report
showed up to 100 issues. One of the major changes
that were not fixed by the
--fixflag were:There are further improvements to be made as
moving away from some of the code in rpkutil and
eliminating the containerutil package but these
will be handled in separate commits to not hinder
the review of this one.
In addition we are also bumping the golangci-lint
version in our Github Actions.
Backports Required
Release Notes