Conversation
There was a problem hiding this comment.
Pull request overview
This PR appears to be a test-related change that modifies test configurations and adds debugging capabilities for cloud topics compaction, along with utility improvements for container serialization.
Changes:
- Simplified test matrix to run with fewer configurations
- Added support for printing
absl::btree_multisetcontainers - Added temporary debugging code with error logging and assertions
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/rptest/tests/random_node_operations_smoke_test.py | Reduced test matrix from [True, False] to [False] for mixed_versions parameter and added cloud_topics-compaction debug logging |
| src/v/utils/to_string.h | Added stream operator overload for absl::btree_multiset to enable printing/debugging |
| src/v/cloud_topics/level_one/metastore/state_update_utils.cc | Added temporary debugging code with error logging and assertion for broken extent updates |
| src/v/cloud_topics/level_one/metastore/BUILD | Added dependencies for logging and formatting utilities |
| src/v/cloud_topics/level_one/compaction/sink.cc | Reversed the order of new_cleaned_ranges vector |
| current_last = extent.last_offset; | ||
| } else { | ||
| vlog(cd_log.error, "BROKEN UPDATE WITH EXTENTS: {}", extents); | ||
| vassert(false, "you broke it."); |
There was a problem hiding this comment.
This debugging code appears to be temporary test instrumentation that should not be committed to the codebase. The assertion will cause production code to crash. If this is intentional debugging code, consider using a feature flag or removing it before merging.
| vassert(false, "you broke it."); |
|
/ci-repeat 5 |
|
/ci-repeat 5 |
These are pushed back in descending order, currently.
more logging
|
/ci-repeat 5 |
Nice |
|
/ci-repeat 5 |
Retry command for Build#80313please wait until all jobs are finished before running the slash command |
|
/ci-repeat 5 |
Retry command for Build#80332please wait until all jobs are finished before running the slash command |
|
/ci-repeat 5 |
|
/ci-repeat 5 |
1 similar comment
|
/ci-repeat 5 |
2 participants
Backports Required
Release Notes