Update Immer dep to 10.2 and disable strict iteration for perf #5127
+22
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d8a894a:
|
size-limit report 📦
|
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
markerikson
force-pushed
the
feature/immer-10.2
branch
from
0532803 to
d8a894a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
strictIterationoption to false (ie assume no symbol keys in state updates for faster iteration). Based on my benchmarks, this provides a ~10% speedup. That call is done in thecreateReducerfile, so it always applies (except the highly unlikely case someone isn't writing any reducers / not using RTKQ)It's technically possible that there might be Redux users relying on symbols as keys in state, but in practice this is not how we intend Redux to be used, and therefore this is not considered a breaking change. If by chance this affects someone, there's an easy fix - import and call
setUseStrictIteration(true)in your own app code.Given that this should be a free 10% perf win for all RTK users, it's an easy choice to turn this on.