-
Notifications
You must be signed in to change notification settings - Fork 2
Update coaching sessions #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
6f0be1a
add the ability to update a coaching session
calebbourg 3b21b68
separate form from dialog
calebbourg 413981c
PR comments
calebbourg f18b415
move join session button back out of dropdown
calebbourg 704b933
fix regressions from updating coaching session dialog
calebbourg e9cb3e7
refactor coaching session creation/updates
calebbourg d79bbce
refresh coaching session list after delete
calebbourg dbc6966
only coaches can delete coaching sessions
calebbourg a17885a
Merge pull request #100 from refactor-group/delete_coaching_sessions
jhodapp 962040b
Removes the SelectCoachingRelationship component from the Dashboard p…
jhodapp 3982109
Move the CoachingSessionSelector into the CoachingSessionList, refact…
jhodapp c851b3a
Clean up the select coaching relationship placeholder text to be clea…
jhodapp 28cd840
We no longer need to debug print relationships.
jhodapp e29da27
We no longer need to debug print relationships in useEffect either.
jhodapp 6e64e99
Handle loading/loading error cases better for the coaching session list.
jhodapp 536a763
use edit and delete language
calebbourg 0630dbb
use edit and delete language
calebbourg 66000f8
Address review comments
jhodapp 14ddebb
Merge pull request #104 from refactor-group/remove_org_and_rel_select…
jhodapp e3ef1f5
merge dashboard-content and dashboard-container
calebbourg 7c6ada9
Move the DashboardContainer component into the components directory.
jhodapp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,51 +1,11 @@ | ||
import type { Metadata } from "next"; | ||
import type * as React from "react"; | ||
import { cn } from "@/components/lib/utils"; | ||
import SelectCoachingRelationship from "@/components/ui/dashboard/select-coaching-relationship"; | ||
import CoachingSessionList from "@/components/ui/dashboard/coaching-session-list"; | ||
import AddEntities from "@/components/ui/dashboard/add-entities"; | ||
import { DashboardContainer } from "../../components/ui/dashboard/dashboard-container"; | ||
|
||
export const metadata: Metadata = { | ||
title: "Dashboard", | ||
description: "Coaching dashboard", | ||
}; | ||
|
||
function DashboardContainer({ | ||
className, | ||
...props | ||
}: React.HTMLAttributes<HTMLDivElement>) { | ||
return ( | ||
<div | ||
className={cn( | ||
// Base styles | ||
"p-4", | ||
// Mobile: stack vertically | ||
"flex flex-col gap-6", | ||
// Tablet and up (640px+): side by side | ||
"sm:grid sm:grid-cols-2", | ||
// Never grow wider than the site-header | ||
"max-w-screen-2xl", | ||
// Ensure full width for children | ||
"[&>*]:w-full", | ||
className | ||
)} | ||
{...props} | ||
/> | ||
); | ||
} | ||
|
||
export default function DashboardPage() { | ||
return ( | ||
<> | ||
<div className="p-4 max-w-screen-2xl"> | ||
<div className="mb-8 w-full"> | ||
<AddEntities /> | ||
</div> | ||
</div> | ||
<DashboardContainer> | ||
<SelectCoachingRelationship /> | ||
<CoachingSessionList /> | ||
</DashboardContainer> | ||
</> | ||
); | ||
return <DashboardContainer />; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
130 changes: 0 additions & 130 deletions
130
src/components/ui/dashboard/add-coaching-session-dialog.tsx
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be consistent with Agreements and Actions, can you update the drop down menu item text to be "Edit" and "Delete" instead of "Update Session" and "Delete Session"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated 536a763