Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

82 feature request suggestion create fe image workflow #99

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

lmcdonough
Copy link

@lmcdonough lmcdonough commented Apr 4, 2025

This pull request introduces a new GitHub Actions workflow for building and pushing the frontend Docker image, and also updates the Dockerfile to improve the build process and runtime configuration. The key changes are grouped by theme below:

GitHub Actions Workflow:

  • Added a new workflow .github/workflows/build_and_push_image.yml to build and push the frontend Docker image on specific events (push, pull request, workflow dispatch). This includes setting up QEMU for multi-arch builds, logging into GitHub Container Registry, building and pushing the Docker image, and signing the image with Cosign.

Dockerfile Enhancements:

  • Updated Dockerfile to include build platform context, optional diagnostics, and improved handling of build-time arguments. This ensures better multi-arch support and more informative build logs.
  • Simplified environment variable handling by consolidating echo statements into a single RUN command for better readability and debugging.
  • Changed the exposed port from a dynamic environment variable to a fixed port 3000 to align with the frontend service configuration.

Changes

  • Modifies Dockerfile
  • Creates GitHub Actions Workflow to build images and store in ghcr

Note pairs with backend Issue #82

@lmcdonough lmcdonough added the feature work Specifically implementing a new feature label Apr 4, 2025
@lmcdonough lmcdonough requested a review from jhodapp April 4, 2025 21:14
@lmcdonough lmcdonough self-assigned this Apr 4, 2025
@jhodapp jhodapp moved this to 🏗 In progress in Refactor Coaching Platform Apr 5, 2025
@jhodapp jhodapp added this to the 1.0-beta1 milestone Apr 5, 2025
@lmcdonough lmcdonough force-pushed the 82-feature-request-suggestion-create-fe-image-workflow branch from 0f2ddbf to 0e13db9 Compare April 9, 2025 23:24
@lmcdonough lmcdonough marked this pull request as ready for review April 9, 2025 23:42
@jhodapp jhodapp moved this from 🏗 In progress to Review in Refactor Coaching Platform Apr 11, 2025
Copy link
Member

@jhodapp jhodapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very clean and great Levi, thank you for this. I have a few suggested changes inline, nothing too major and then I'm happy to approve.

Also, is there an easy way for me to test this ahead of landing it since it's isolated to just your branch for this PR for now?

@lmcdonough lmcdonough force-pushed the 82-feature-request-suggestion-create-fe-image-workflow branch from c0031a2 to 3f0dc41 Compare April 11, 2025 16:22
@lmcdonough lmcdonough requested a review from jhodapp April 11, 2025 16:24
@jhodapp jhodapp requested a review from calebbourg April 11, 2025 18:46
Copy link
Member

@jhodapp jhodapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature work Specifically implementing a new feature
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

2 participants