-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
82 feature request suggestion create fe image workflow #99
base: main
Are you sure you want to change the base?
82 feature request suggestion create fe image workflow #99
Conversation
0f2ddbf
to
0e13db9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very clean and great Levi, thank you for this. I have a few suggested changes inline, nothing too major and then I'm happy to approve.
Also, is there an easy way for me to test this ahead of landing it since it's isolated to just your branch for this PR for now?
c0031a2
to
3f0dc41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
This pull request introduces a new GitHub Actions workflow for building and pushing the frontend Docker image, and also updates the
Dockerfile
to improve the build process and runtime configuration. The key changes are grouped by theme below:GitHub Actions Workflow:
.github/workflows/build_and_push_image.yml
to build and push the frontend Docker image on specific events (push, pull request, workflow dispatch). This includes setting up QEMU for multi-arch builds, logging into GitHub Container Registry, building and pushing the Docker image, and signing the image with Cosign.Dockerfile Enhancements:
Dockerfile
to include build platform context, optional diagnostics, and improved handling of build-time arguments. This ensures better multi-arch support and more informative build logs.RUN
command for better readability and debugging.3000
to align with the frontend service configuration.Changes
Note pairs with backend Issue #82