Skip to content

Add isForkingRepo #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025
Merged

Add isForkingRepo #209

merged 2 commits into from
Jun 18, 2025

Conversation

kovsu
Copy link
Member

@kovsu kovsu commented Jun 18, 2025

@kovsu kovsu changed the title Add isForkingRepo Add isFork Jun 18, 2025
@fregante
Copy link
Member

Do you know how to release this package after merging this PR? You can type "minor" in the version field

@kovsu
Copy link
Member Author

kovsu commented Jun 18, 2025

@fregante I think I know.

@kovsu kovsu merged commit 78a01f9 into refined-github:main Jun 18, 2025
15 checks passed
@kovsu kovsu deleted the 06-18-is-forking branch June 18, 2025 03:20
@kovsu
Copy link
Member Author

kovsu commented Jun 18, 2025

@fregante You should help me to clean the lateset version https://www.npmjs.com/package/github-url-detection

I messed the steps. Now I konw how to do it. 😢

@fregante
Copy link
Member

What do you mean by clean?

@@ -567,6 +567,11 @@ TEST: addTests('isRepoNetworkGraph', [

export const isForkedRepo = (): boolean => exists('meta[name="octolytics-dimension-repository_is_fork"][content="true"]');

export const isFork = (url: URL | HTMLAnchorElement | Location = location): boolean => getRepo(url)?.path === 'fork';
TEST: addTests('isFork', [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be isForkingRepo.

isFork is ambiguous. New PR, then you can release a new "patch" version afterwards

@fregante
Copy link
Member

I think you pushed the tags directly to the repo from your computer and the CI failed? No need to do that, just type "patch" in the version field and the workflow does it all

@kovsu
Copy link
Member Author

kovsu commented Jun 18, 2025

I think you pushed the tags directly to the repo from your computer and the CI failed? No need to do that, just type "patch" in the version field and the workflow does it all

Yeah. Let's go to v10.2.1.

@fregante
Copy link
Member

All good now! By the way I really meant you can enter patch, not the version. See my last release

image

image

@fregante fregante changed the title Add isFork Add isForkingRepo Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants