fix(core): add dynamic ids as part of breadcrumbs #6654
+309
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- display end id when on action(show/edit) page - display nested id in route - add test case for these - add changeset
🦋 Changeset detectedLatest commit: 56b270e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for refine-doc-live-previews ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@arndom, I have quickly reviewed the PR and you check for |
- to match ids like: `:orgId`, `:projectId`, not just `:id`
|
Thanks for catching that @aress31, fixed now |
refine
|
||||||||||||||||||||||||||||||||||
| Project |
refine
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 20m 28s |
| Commit |
|
| Committer | Necati Özmen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
22
|
Skipped
|
0
|
Passing
|
377
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/table-material-ui-advanced/data-grid.cy.ts • 1 failed test • table-material-ui-advanced
| Test | Artifacts | |
|---|---|---|
| table-material-ui-advanced > should work with filter |
Test Replay
Screenshots
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/:idin breadcrumb when on action(show/edit) page/:idin breadcrumbPR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
Dynamic ids (route param) are not included in the breadcrumb
What is the new behavior?
Dynamic ids are now included in the breadcrumb
fixes (issue)
#6584
Notes for reviewers