Skip to content

enable UP ruff rule #5137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 16, 2025
Merged

enable UP ruff rule #5137

merged 3 commits into from
Apr 16, 2025

Conversation

adhami3310
Copy link
Member

No description provided.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 15, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #5137 will improve performances by 4.33%

Comparing enable-UP-ruff-rule (2b1e01d) with main (90512dc)

Summary

⚡ 5 improvements
✅ 7 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ test_compile_page[_complicated_page] 127.7 ms 123 ms +3.78%
⚡ test_compile_page[_stateful_page] 16.6 ms 15.9 ms +4.33%
⚡ test_evaluate_page[_complicated_page] 64.5 ms 62.2 ms +3.6%
⚡ test_evaluate_page[_simple_page] 851.1 µs 823.2 µs +3.38%
⚡ test_evaluate_page[_stateful_page] 8.6 ms 8.3 ms +3.4%

Lendemor
Lendemor reviewed Apr 16, 2025
View reviewed changes
Lendemor
Lendemor previously approved these changes Apr 16, 2025
View reviewed changes
@adhami3310 adhami3310 merged commit 642233b into main Apr 16, 2025
42 checks passed
@adhami3310 adhami3310 deleted the enable-UP-ruff-rule branch April 16, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lendemor Lendemor Lendemor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adhami3310 @Lendemor