Skip to content

Allow custom toast message in production mode by adding optional connection_error_message arg in rx.config #6060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoaquinVeraOrtega wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −1
Open

Allow custom toast message in production mode by adding optional connection_error_message arg in rx.config #6060

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d14f28
Add connection_error_message to configuration for custom connection e…
JoaquinVeraOrtega Dec 19, 2025
5993ed4
refactor(connection_toaster): extract duplicated dev mode check to va…
JoaquinVeraOrtega Dec 20, 2025
9fefbc8
Remove REFLEX_ENV_MODE checks from ConnectionToaster
JoaquinVeraOrtega Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion reflex/components/core/banner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from reflex.components.radix.themes.layout.flex import Flex
from reflex.components.radix.themes.typography.text import Text
from reflex.components.sonner.toast import ToastProps, toast_ref
from reflex.config import get_config
from reflex.constants import Dirs, Hooks, Imports
from reflex.constants.compiler import CompileVars
from reflex.environment import environment
Expand Down Expand Up @@ -100,9 +101,13 @@ def add_hooks(self) -> list[str | Var]:
"""
toast_id = "websocket-error"
target_url = WebsocketTargetURL.create()
config = get_config()
is_dev_mode = environment.REFLEX_ENV_MODE.get().value == constants.Env.DEV
Copy link
Member

@adhami3310 adhami3310 Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it be simpler to change the responsibility of providing this to the config provider? meaning, in rxconfig you only provide connection error message when on prod

Copy link
Author

@JoaquinVeraOrtega JoaquinVeraOrtega Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, added new commit removing those env mode checks

props = ToastProps(
description=LiteralVar.create(
f"Check if server is reachable at {target_url}",
f"Check if server is reachable at {target_url}"
if is_dev_mode or not config.connection_error_message
else config.connection_error_message
),
close_button=True,
duration=120000,
Expand Down Expand Up @@ -135,6 +140,8 @@ def add_hooks(self) -> list[str | Var]:
else:
loading_message = Var.create(
f"Cannot connect to server: {connection_error}."
if is_dev_mode or not config.connection_error_message
else ""
Copy link
Member

@adhami3310 adhami3310 Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be connection error message?

Copy link
Author

@JoaquinVeraOrtega JoaquinVeraOrtega Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would duplicate the error message. The connection error toast has two parts, title and description, but since I'm setting one error message in rxconfig I figured just pass the message in the title and leave the description empty.

)
toast_var = Var(
f"toast?.error({loading_message!s}, {{...toast_props, onDismiss: () => setUserDismissed(true)}},)"
Expand Down
2 changes: 2 additions & 0 deletions reflex/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,8 @@ class BaseConfig:

_prefixes: ClassVar[list[str]] = ["REFLEX_"]

connection_error_message: str | None = None


_PLUGINS_ENABLED_BY_DEFAULT = [
SitemapPlugin,
Expand Down