Show upload preview without error #119
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new macro which will show the upload form without relying on any macros that are not installed because we are showing the preview by just showing the template on the page. As a result the preview.show() macro needs to import all of the govuk components (which are not installed in the importer, but will be when showing the preview) for any govuk components. Unfortunately, when installing this template, it will keep the block that decides to show the preview and will likely generate support questions around its presence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new macro which will show the upload form without relying on any macros that are not installed because we are showing the preview by just showing the template on the page.
As a result the preview.show() macro needs to import all of the govuk components (which are not installed in the importer, but will be when showing the preview) for any govuk components.
Unfortunately, when installing this template, it will keep the block that decides to show the preview and will likely generate support questions around its presence.
This PR is just to show the result of attempting this approach to fix #63