Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddedUserNameReq #542

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions regolith/storage.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,18 +88,19 @@ def push_git(store, path, rc):
subprocess.check_call(cmd, cwd=storedir)
if "default_user_id" in rc:
cmd = ["git", "commit", "-m", f"{rc.default_user_id} regolith auto-store commit"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment on the other PR. It looks as we may need default_github_id in regolithrc.json

try:
subprocess.check_call(cmd, cwd=storedir)
except subprocess.CalledProcessError:
warn("Could not git commit to " + storedir, RuntimeWarning)
return
cmd = ["git", "push"]
try:
subprocess.check_call(cmd, cwd=storedir)
except subprocess.CalledProcessError:
warn("Could not git push from " + storedir, RuntimeWarning)
return
else:
print('Please add default_user_id to user.json in .config/regolith folder')
try:
subprocess.check_call(cmd, cwd=storedir)
except subprocess.CalledProcessError:
warn("Could not git commit to " + storedir, RuntimeWarning)
return
cmd = ["git", "push"]
try:
subprocess.check_call(cmd, cwd=storedir)
except subprocess.CalledProcessError:
warn("Could not git push from " + storedir, RuntimeWarning)
return


Expand Down